Make bookmark bar folder buttons look active so long as the menu is open....

Make bookmark bar folder buttons look active so long as the menu is open.

Make sure chrome buttons have no child displacement (so the contents don't jiggle when you press them).

BUG=none
TEST=do a click on a folder, click away, make sure the button always looks as you'd expect


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20203

[Elliot Glaysher, 2009-07-08 22:14:39]

http://codereview.chromium.org/149355/diff/1/5
File chrome/browser/gtk/bookmark_bar_gtk.cc (right):

http://codereview.chromium.org/149355/diff/1/5#newcode536
Line 536: GTK_IS_CHROME_BUTTON(sender)) {
This makes the bookmark contents menu pop up on mousedown, right? How does this
interact with dragging the folder?

[Evan Stade, 2009-07-08 22:28:30]

ah, good call. This messes with dragging. I guess we could set the menu display
on a timer, but that would defeat the purpose as you couldn't click, drag down,
and release, unless you waited a while first. That part of the change is
reverted (I will update the desc. shortly). Linux firefox "fixes" this problem
by making folders on the bookmark bar undraggable.

I added some styling to chrome buttons to make them look more consistent (which
matches windows chrome, linux firefox, and makes it so the contents of the
folder button don't jiggle at the end of a button press).

[Elliot Glaysher, 2009-07-08 22:37:47]

New version LGTM.