Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1432)

Unified Diff: chrome/browser/gtk/bookmark_menu_controller_gtk.h

Issue 149355: Make bookmark bar folder buttons look active so long as the menu is open.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/gtk/bookmark_menu_controller_gtk.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_menu_controller_gtk.h
===================================================================
--- chrome/browser/gtk/bookmark_menu_controller_gtk.h (revision 20108)
+++ chrome/browser/gtk/bookmark_menu_controller_gtk.h (working copy)
@@ -34,7 +34,7 @@
bool show_other_folder);
virtual ~BookmarkMenuController();
- // Pops up the menu.
+ // Pops up the menu. |widget| must be a GtkChromeButton.
void Popup(GtkWidget* widget, gint button_type, guint32 timestamp);
// Overridden from BaseBookmarkModelObserver:
@@ -64,6 +64,10 @@
GdkEventButton* event,
BookmarkMenuController* controller);
+ // We have to stop drawing |triggering_widget_| as active when the menu
+ // closes.
+ static void OnMenuHidden(GtkWidget* menu, BookmarkMenuController* controller);
+
// We respond to the activate signal because things other than mouse button
// events can trigger it.
static void OnMenuItemActivated(GtkMenuItem* menuitem,
@@ -105,6 +109,9 @@
// dragging).
bool ignore_button_release_;
+ // The widget we are showing for (i.e. the bookmark bar folder button).
+ GtkWidget* triggering_widget_;
+
// Mapping from node to GtkMenuItem menu id. This only contains entries for
// nodes of type URL.
std::map<const BookmarkNode*, GtkWidget*> node_to_menu_widget_map_;
« no previous file with comments | « no previous file | chrome/browser/gtk/bookmark_menu_controller_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698