Issue 149351: Fix crash bug in ARM codegenerator by adding another special case for...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149351: Fix crash bug in ARM codegenerator by adding another special case for... (Closed)

Created:
11 years, 5 months ago by Mads Ager (chromium)

Modified:
3 years, 5 months ago

Reviewers:
iposva, Kevin Millikin (Chromium), angel

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix crash bug in ARM codegenerator by adding another special case for generating code after a call to LoadConditionAndSpill. This crash is hit on www.rightmove.co.uk when using the ARM codegenerator. Committed: http://code.google.com/p/v8/source/detail?r=2400

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	src/arm/codegen-arm.cc	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

angel

3 years, 5 months ago (2017-06-26 16:16:20 UTC) #3

Message was sent while issue was closed.

On 2009/07/08 21:55:27, iposva wrote:
> Please add comment as discussed, otherwise LGTM.
> -Ivan

This crash also hit on https://astakov.com when using the ARM codegenerator.

Expand Messages | Collapse Messages