Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 149351: Fix crash bug in ARM codegenerator by adding another special case for... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2006-2009 the V8 project authors. All rights reserved. 1 // Copyright 2006-2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3597 matching lines...) Expand 10 before | Expand all | Expand 10 after
3608 Comment cmnt(masm_, "[ UnaryOperation"); 3608 Comment cmnt(masm_, "[ UnaryOperation");
3609 3609
3610 Token::Value op = node->op(); 3610 Token::Value op = node->op();
3611 3611
3612 if (op == Token::NOT) { 3612 if (op == Token::NOT) {
3613 LoadConditionAndSpill(node->expression(), 3613 LoadConditionAndSpill(node->expression(),
3614 NOT_INSIDE_TYPEOF, 3614 NOT_INSIDE_TYPEOF,
3615 false_target(), 3615 false_target(),
3616 true_target(), 3616 true_target(),
3617 true); 3617 true);
3618 cc_reg_ = NegateCondition(cc_reg_); 3618 // LoadConditionAndSpill might emit only unconditional jumps to
3619 // the targets in which case cc_reg_ is not set. When that
3620 // happens, don't attempt to negate the condition.
3621 if (has_cc()) cc_reg_ = NegateCondition(cc_reg_);
3619 3622
3620 } else if (op == Token::DELETE) { 3623 } else if (op == Token::DELETE) {
3621 Property* property = node->expression()->AsProperty(); 3624 Property* property = node->expression()->AsProperty();
3622 Variable* variable = node->expression()->AsVariableProxy()->AsVariable(); 3625 Variable* variable = node->expression()->AsVariableProxy()->AsVariable();
3623 if (property != NULL) { 3626 if (property != NULL) {
3624 LoadAndSpill(property->obj()); 3627 LoadAndSpill(property->obj());
3625 LoadAndSpill(property->key()); 3628 LoadAndSpill(property->key());
3626 Result arg_count = allocator_->Allocate(r0); 3629 Result arg_count = allocator_->Allocate(r0);
3627 ASSERT(arg_count.is_valid()); 3630 ASSERT(arg_count.is_valid());
3628 __ mov(arg_count.reg(), Operand(1)); // not counting receiver 3631 __ mov(arg_count.reg(), Operand(1)); // not counting receiver
(...skipping 2775 matching lines...) Expand 10 before | Expand all | Expand 10 after
6404 int CompareStub::MinorKey() { 6407 int CompareStub::MinorKey() {
6405 // Encode the two parameters in a unique 16 bit value. 6408 // Encode the two parameters in a unique 16 bit value.
6406 ASSERT(static_cast<unsigned>(cc_) >> 28 < (1 << 15)); 6409 ASSERT(static_cast<unsigned>(cc_) >> 28 < (1 << 15));
6407 return (static_cast<unsigned>(cc_) >> 27) | (strict_ ? 1 : 0); 6410 return (static_cast<unsigned>(cc_) >> 27) | (strict_ ? 1 : 0);
6408 } 6411 }
6409 6412
6410 6413
6411 #undef __ 6414 #undef __
6412 6415
6413 } } // namespace v8::internal 6416 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698