Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 149348: Linux: Add First Run UI. (Closed)

Created:
11 years, 5 months ago by kuchhal
Modified:
9 years, 7 months ago
Reviewers:
Evan Martin, Evan Stade
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: Add "set chrome as default" and "import profile data" option to First Run UI. Also enable it for Chromium builds.

Patch Set 1 #

Total comments: 3

Patch Set 2 : code review feedback #

Patch Set 3 : merge to tot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -156 lines) Patch
M chrome/browser/browser_main.cc View 1 2 3 chunks +1 line, -31 lines 0 comments Download
M chrome/browser/first_run_gtk.cc View 1 2 1 chunk +5 lines, -125 lines 0 comments Download
A chrome/browser/gtk/first_run_dialog.h View 1 2 1 chunk +54 lines, -0 lines 0 comments Download
A chrome/browser/gtk/first_run_dialog.cc View 1 2 1 chunk +154 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kuchhal
11 years, 5 months ago (2009-07-08 20:24:13 UTC) #1
Evan Martin
evan, do you mind reviewing?
11 years, 5 months ago (2009-07-08 20:40:39 UTC) #2
Evan Stade
can you make the change description more detailed? We already have some first run UI ...
11 years, 5 months ago (2009-07-08 20:53:47 UTC) #3
kuchhal
Added more detailed change description. On Wed, Jul 8, 2009 at 1:53 PM, <estade@chromium.org> wrote: ...
11 years, 5 months ago (2009-07-08 21:04:29 UTC) #4
Evan Stade
11 years, 5 months ago (2009-07-08 21:13:56 UTC) #5
lgtm

http://codereview.chromium.org/149348/diff/1/4
File chrome/browser/gtk/first_run_dialog.cc (right):

http://codereview.chromium.org/149348/diff/1/4#newcode53
Line 53: GtkWidget* privacy_label = gtk_label_new(
can you add a TODO to remove this?

http://codereview.chromium.org/149348/diff/1/4#newcode109
Line 109: // TODO(port): it should be sufficient to just run the dialog:
(I wonder if this is still a problem after piman's fix.)

Powered by Google App Engine
This is Rietveld 408576698