Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 149305: Add the page url to plugin crashes to aid debugging. (Closed)

Created:
11 years, 5 months ago by jam
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), brettw, ananta
Visibility:
Public.

Description

Add the page url to plugin crashes to aid debugging. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20173

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -451 lines) Patch
M chrome/app/breakpad_win.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/chrome.gyp View 4 chunks +5 lines, -5 lines 0 comments Download
A + chrome/common/child_process_logging.h View 2 chunks +20 lines, -20 lines 0 comments Download
A + chrome/common/child_process_logging_linux.cc View 1 chunk +4 lines, -6 lines 0 comments Download
A + chrome/common/child_process_logging_mac.mm View 3 chunks +8 lines, -8 lines 0 comments Download
A + chrome/common/child_process_logging_mac_unittest.mm View 5 chunks +20 lines, -20 lines 0 comments Download
A + chrome/common/child_process_logging_win.cc View 2 chunks +10 lines, -12 lines 0 comments Download
M chrome/common/plugin_messages.h View 4 chunks +5 lines, -0 lines 0 comments Download
M chrome/plugin/npobject_proxy.h View 4 chunks +8 lines, -2 lines 0 comments Download
M chrome/plugin/npobject_proxy.cc View 9 chunks +20 lines, -11 lines 0 comments Download
M chrome/plugin/npobject_stub.h View 3 chunks +6 lines, -1 line 0 comments Download
M chrome/plugin/npobject_stub.cc View 10 chunks +19 lines, -9 lines 0 comments Download
M chrome/plugin/npobject_util.h View 2 chunks +9 lines, -4 lines 0 comments Download
M chrome/plugin/npobject_util.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_delegate_stub.cc View 6 chunks +12 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_proxy.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/plugin/webplugin_proxy.cc View 6 chunks +12 lines, -9 lines 0 comments Download
M chrome/renderer/render_view.cc View 4 chunks +3 lines, -3 lines 0 comments Download
D chrome/renderer/renderer_logging.h View 1 chunk +0 lines, -55 lines 0 comments Download
D chrome/renderer/renderer_logging_linux.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D chrome/renderer/renderer_logging_mac.mm View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/renderer/renderer_logging_mac_unittest.mm View 1 chunk +0 lines, -138 lines 0 comments Download
D chrome/renderer/renderer_logging_win.cc View 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/renderer/webplugin_delegate_proxy.cc View 1 9 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
Ananta: FYI
11 years, 5 months ago (2009-07-08 01:07:17 UTC) #1
sky
11 years, 5 months ago (2009-07-08 15:25:50 UTC) #2 
LGTM

Powered by Google App Engine
This is Rietveld 408576698