Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1463)

Unified Diff: chrome/common/child_process_logging_mac.mm

Issue 149305: Add the page url to plugin crashes to aid debugging. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/child_process_logging_linux.cc ('k') | chrome/common/child_process_logging_mac_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/child_process_logging_mac.mm
===================================================================
--- chrome/common/child_process_logging_mac.mm (revision 20096)
+++ chrome/common/child_process_logging_mac.mm (working copy)
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "chrome/renderer/renderer_logging.h"
+#include "chrome/common/child_process_logging.h"
#import <Foundation/Foundation.h>
@@ -10,15 +10,15 @@
#include "googleurl/src/gurl.h"
#import "chrome/app/breakpad_mac.h"
-namespace renderer_logging {
+namespace child_process_logging {
const int kMaxNumCrashURLChunks = 8;
const int kMaxNumURLChunkValueLength = 255;
const char *kUrlChunkFormatStr = "url-chunk-%d";
-void SetActiveRendererURLImpl(const GURL& url,
- SetCrashKeyValueFuncPtr set_key_func,
- ClearCrashKeyValueFuncPtr clear_key_func) {
+void SetActiveURLImpl(const GURL& url,
+ SetCrashKeyValueFuncPtr set_key_func,
+ ClearCrashKeyValueFuncPtr clear_key_func) {
NSString *kUrlChunkFormatStr_utf8 = [NSString
stringWithUTF8String:kUrlChunkFormatStr];
@@ -59,13 +59,13 @@
}
}
-void SetActiveRendererURL(const GURL& url) {
+void SetActiveURL(const GURL& url) {
// If Breakpad isn't initialized then bail.
if (IsCrashReporterDisabled()) {
return;
}
- SetActiveRendererURLImpl(url, SetCrashKeyValue, ClearCrashKeyValue);
+ SetActiveURLImpl(url, SetCrashKeyValue, ClearCrashKeyValue);
}
-} // namespace renderer_logging
+} // namespace child_process_logging
Property changes on: chrome\common\child_process_logging_mac.mm
___________________________________________________________________
Added: svn:eol-style
+ LF
« no previous file with comments | « chrome/common/child_process_logging_linux.cc ('k') | chrome/common/child_process_logging_mac_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698