Issue 149289: Disable NPAPIIncognitoTester.PrivateEnabled test because it's flaky.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149289: Disable NPAPIIncognitoTester.PrivateEnabled test because it's flaky. (Closed)

Created:
11 years, 5 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
jam

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Disable NPAPIIncognitoTester.PrivateEnabled test because it's flaky. TBR=jam Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20098

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	webkit/glue/plugins/test/plugin_client.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jam

11 years, 5 months ago (2009-07-07 22:52:36 UTC) #2

This isn't how a test is disabled.  It should be done with putting DISABLED_
around the name in the uitest file.

On Tue, Jul 7, 2009 at 3:47 PM, <jhawkins@chromium.org> wrote:

> Reviewers: John Abd-El-Malek,
>
> Description:
> Disable NPAPIIncognitoTester.PrivateEnabled test because it's flaky.
>
> TBR=jam
>
> Please review this at http://codereview.chromium.org/149289
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     webkit/glue/plugins/test/plugin_client.cc
>
>
> Index: webkit/glue/plugins/test/plugin_client.cc
> ===================================================================
> --- webkit/glue/plugins/test/plugin_client.cc   (revision 20091)
> +++ webkit/glue/plugins/test/plugin_client.cc   (working copy)
> @@ -149,8 +149,11 @@
>     new_test = new
> NPAPIClient::ExecuteJavascriptPopupWindowTargetPluginTest(
>         instance, NPAPIClient::PluginClient::HostFunctions());
>   } else if (test_name == "private") {
> +// http://code.google.com/p/chromium/issues/detail?id=16149
> +#if 0
>     new_test = new NPAPIClient::PrivateTest(instance,
>       NPAPIClient::PluginClient::HostFunctions());
> +#endif
>  #if defined(OS_WIN)
>   // TODO(port): plugin_windowed_test.*.
>   } else if (test_name == "hidden_plugin" ||
>
>
>

Expand Messages | Collapse Messages