Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/unload_uitest.cc

Issue 149281: Sprinkle some defensiveness into the UI tests so that they don't explode if t... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/tab_restore_uitest.cc ('k') | chrome/browser/views/find_bar_win_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/unload_uitest.cc
===================================================================
--- chrome/browser/unload_uitest.cc (revision 19956)
+++ chrome/browser/unload_uitest.cc (working copy)
@@ -336,7 +336,7 @@
TEST_F(UnloadTest, DISABLED_BrowserCloseTabWhenOtherTabHasListener) {
NavigateToDataURL(CLOSE_TAB_WHEN_OTHER_TAB_HAS_LISTENER, L"only_one_unload");
int window_count;
- automation()->GetBrowserWindowCount(&window_count);
+ ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
ASSERT_EQ(2, window_count);
scoped_refptr<BrowserProxy> popup_browser_proxy(
@@ -346,6 +346,7 @@
EXPECT_TRUE(popup_browser_proxy->GetTabCount(&popup_tab_count));
EXPECT_EQ(1, popup_tab_count);
scoped_refptr<TabProxy> popup_tab(popup_browser_proxy->GetActiveTab());
+ ASSERT_TRUE(popup_tab.get());
std::wstring popup_title;
ASSERT_TRUE(popup_tab.get() != NULL);
EXPECT_TRUE(popup_tab->GetTabTitle(&popup_title));
@@ -359,6 +360,7 @@
EXPECT_TRUE(main_browser_proxy->GetTabCount(&main_tab_count));
EXPECT_EQ(1, main_tab_count);
scoped_refptr<TabProxy> main_tab(main_browser_proxy->GetActiveTab());
+ ASSERT_TRUE(main_tab.get());
std::wstring main_title;
ASSERT_TRUE(main_tab.get() != NULL);
EXPECT_TRUE(main_tab->GetTabTitle(&main_title));
« no previous file with comments | « chrome/browser/tab_restore_uitest.cc ('k') | chrome/browser/views/find_bar_win_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698