Sprinkle some defensiveness into the UI tests so that they don't explode if t...

chrome/browser/unload_uitest.cc

 // Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "app/message_box_flags.h"
 #include "base/file_util.h"
 #include "base/platform_thread.h"
 #include "chrome/browser/automation/url_request_mock_http_job.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/automation/browser_proxy.h"
@@ skipping 318 matching lines @@
 
 // TODO(brettw) bug 12913 this test was broken by WebKit merge 42202:44252.
 // Apparently popup titles are broken somehow.
 
 // Tests that if there's a renderer process with two tabs, one of which has an
 // unload handler, and the other doesn't, the tab that doesn't have an unload
 // handler can be closed.  If this test fails, the Close() call will hang.
 TEST_F(UnloadTest, DISABLED_BrowserCloseTabWhenOtherTabHasListener) {
   NavigateToDataURL(CLOSE_TAB_WHEN_OTHER_TAB_HAS_LISTENER, L"only_one_unload");
   int window_count;
-  automation()->GetBrowserWindowCount(&window_count);
+  ASSERT_TRUE(automation()->GetBrowserWindowCount(&window_count));
   ASSERT_EQ(2, window_count);
 
   scoped_refptr<BrowserProxy> popup_browser_proxy(
       automation()->GetBrowserWindow(1));
   ASSERT_TRUE(popup_browser_proxy.get());
   int popup_tab_count;
   EXPECT_TRUE(popup_browser_proxy->GetTabCount(&popup_tab_count));
   EXPECT_EQ(1, popup_tab_count);
   scoped_refptr<TabProxy> popup_tab(popup_browser_proxy->GetActiveTab());
+  ASSERT_TRUE(popup_tab.get());
   std::wstring popup_title;
   ASSERT_TRUE(popup_tab.get() != NULL);
   EXPECT_TRUE(popup_tab->GetTabTitle(&popup_title));
   EXPECT_EQ(std::wstring(L"popup"), popup_title);
   EXPECT_TRUE(popup_tab->Close(true));
 
   scoped_refptr<BrowserProxy> main_browser_proxy(
       automation()->GetBrowserWindow(0));
   ASSERT_TRUE(main_browser_proxy.get());
   int main_tab_count;
   EXPECT_TRUE(main_browser_proxy->GetTabCount(&main_tab_count));
   EXPECT_EQ(1, main_tab_count);
   scoped_refptr<TabProxy> main_tab(main_browser_proxy->GetActiveTab());
+  ASSERT_TRUE(main_tab.get());
   std::wstring main_title;
   ASSERT_TRUE(main_tab.get() != NULL);
   EXPECT_TRUE(main_tab->GetTabTitle(&main_title));
   EXPECT_EQ(std::wstring(L"only_one_unload"), main_title);
 }
 
 // TODO(ojan): Add tests for unload/beforeunload that have multiple tabs
 // and multiple windows.