Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 149276: Mac version of the download shelf views (Closed)

Created:
11 years, 5 months ago by Paul Godavari
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, Ben Goodger (Google)
Visibility:
Public.

Description

The Mac version of the download shelf from the original CL by thakis: http://codereview.chromium.org/150216 Original description: Move download item to its own view and a xib, paving the way for a custom download item view. I didn't change the look of the download items yet. The context menu is now in the download item xib as well. BUG=14659, 15098, 14660 TEST=Download something. Everything should look like before (except for the smaller icon), but the context menu items should be disabled/enabled and checked/unchecked correctly. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20200

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Total comments: 6

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+948 lines, -211 lines) Patch
A chrome/app/nibs/en.lproj/DownloadItem.xib View 1 1 chunk +700 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/download_item_controller.h View 1 2 3 4 5 6 1 chunk +40 lines, -0 lines 0 comments Download
A chrome/browser/cocoa/download_item_controller.mm View 1 2 3 4 5 6 1 chunk +133 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/download_item_mac.h View 1 2 3 4 5 6 7 2 chunks +8 lines, -12 lines 0 comments Download
M chrome/browser/cocoa/download_item_mac.mm View 1 2 3 4 5 6 7 2 chunks +4 lines, -141 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_controller.h View 1 2 3 4 5 6 7 3 chunks +11 lines, -8 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_controller.mm View 1 2 3 4 5 6 7 5 chunks +48 lines, -15 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_mac.h View 1 2 3 4 5 6 7 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/cocoa/download_shelf_mac.mm View 1 2 3 4 5 6 7 2 chunks +1 line, -32 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 6 7 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Godavari
Originally was http://codereview.chromium.org/150216 This new CL includes fixes for your comments in the previous version, ...
11 years, 5 months ago (2009-07-07 22:41:34 UTC) #1
pink (ping after 24hrs)
11 years, 5 months ago (2009-07-08 14:24:07 UTC) #2
LGTM with small issues addressed.

http://codereview.chromium.org/149276/diff/1037/55
File chrome/browser/cocoa/download_item_controller.h (right):

http://codereview.chromium.org/149276/diff/1037/55#newcode26
Line 26: // Takes ownership of |download_model|.
update comment with new name

http://codereview.chromium.org/149276/diff/1037/55#newcode30
Line 30: - (void)setStateFromDownload:(BaseDownloadItemModel*)downloadModel;
comment for function in public API. What state does it set?

http://codereview.chromium.org/149276/diff/1037/56
File chrome/browser/cocoa/download_item_controller.mm (right):

http://codereview.chromium.org/149276/diff/1037/56#newcode49
Line 49: [self setStateFromDownload:bridge_->download_model()];
indented too far?

http://codereview.chromium.org/149276/diff/1037/56#newcode70
Line 70: // TODO(paulg): Use IconManager for loading icons on the file thread.
file a bug so we don't forget? or is that overkill because it's already on your
radar?

http://codereview.chromium.org/149276/diff/1037/56#newcode86
Line 86: - (BOOL)validateMenuItem:(NSMenuItem *)item {
function-level comment.

http://codereview.chromium.org/149276/diff/1037/60
File chrome/browser/cocoa/download_shelf_controller.mm (right):

http://codereview.chromium.org/149276/diff/1037/60#newcode175
Line 175: DownloadItemController* controller =
you can just make this a scoped_nsobject rather than doing the autorelease on
the separate line.

Powered by Google App Engine
This is Rietveld 408576698