DevTools: paint devtools split with COLOR_TOOLBAR....

DevTools: paint devtools split with COLOR_TOOLBAR.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20257

[sky, 2009-07-07 17:33:49]

http://codereview.chromium.org/149258/diff/1/3
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/149258/diff/1/3#newcode1445
Line 1445: views::Background::CreateSolidBackground(bg_color));
Should we do this for all split bars, and not just this one?

[pfeldman, 2009-07-07 17:56:29]

http://codereview.chromium.org/149258/diff/1/3
File chrome/browser/views/frame/browser_view.cc (right):

http://codereview.chromium.org/149258/diff/1/3#newcode1445
Line 1445: views::Background::CreateSolidBackground(bg_color));
On 2009/07/07 17:33:49, sky wrote:
> Should we do this for all split bars, and not just this one?

I am not an expert here at all, so looking for your (or Ben's) advice. I am open
to doing this in the component itself if this is the right way of handling this.
I saw this constant being used in the status bar. At the same time bookmark
manager uses hard-coded values for background. I was thinking using theme for
the browser_view would be the right thing...

[sky, 2009-07-07 18:02:02]

On 2009/07/07 17:56:29, pfeldman wrote:
> http://codereview.chromium.org/149258/diff/1/3
> File chrome/browser/views/frame/browser_view.cc (right):
> 
> http://codereview.chromium.org/149258/diff/1/3#newcode1445
> Line 1445: views::Background::CreateSolidBackground(bg_color));
> On 2009/07/07 17:33:49, sky wrote:
> > Should we do this for all split bars, and not just this one?
> 
> I am not an expert here at all, so looking for your (or Ben's) advice. I am
open
> to doing this in the component itself if this is the right way of handling
this.
> I saw this constant being used in the status bar. At the same time bookmark
> manager uses hard-coded values for background. I was thinking using theme for
> the browser_view would be the right thing...

Glen knows these constants better than I. Glen?

[Glen Murphy, 2009-07-08 21:55:01]

We should use COLOR_TOOLBAR for pretty much everything inside a tab.

We can pretty it up with overlaid edge images (as we do for the toolbar) later.

On 2009/07/07 18:02:02, sky wrote:
> On 2009/07/07 17:56:29, pfeldman wrote:
> > http://codereview.chromium.org/149258/diff/1/3
> > File chrome/browser/views/frame/browser_view.cc (right):
> > 
> > http://codereview.chromium.org/149258/diff/1/3#newcode1445
> > Line 1445: views::Background::CreateSolidBackground(bg_color));
> > On 2009/07/07 17:33:49, sky wrote:
> > > Should we do this for all split bars, and not just this one?
> > 
> > I am not an expert here at all, so looking for your (or Ben's) advice. I am
> open
> > to doing this in the component itself if this is the right way of handling
> this.
> > I saw this constant being used in the status bar. At the same time bookmark
> > manager uses hard-coded values for background. I was thinking using theme
for
> > the browser_view would be the right thing...
> 
> Glen knows these constants better than I. Glen?

[sky, 2009-07-08 21:58:17]

The question is, do we want to use this for the bookmark manager?

  -Scott

On Wed, Jul 8, 2009 at 2:55 PM, <glen@chromium.org> wrote:
> We should use COLOR_TOOLBAR for pretty much everything inside a tab.
>
> We can pretty it up with overlaid edge images (as we do for the toolbar)
> later.
>
> On 2009/07/07 18:02:02, sky wrote:
>>
>> On 2009/07/07 17:56:29, pfeldman wrote:
>> > http://codereview.chromium.org/149258/diff/1/3
>> > File chrome/browser/views/frame/browser_view.cc (right):
>> >
>> > http://codereview.chromium.org/149258/diff/1/3#newcode1445
>> > Line 1445: views::Background::CreateSolidBackground(bg_color));
>> > On 2009/07/07 17:33:49, sky wrote:
>> > > Should we do this for all split bars, and not just this one?
>> >
>> > I am not an expert here at all, so looking for your (or Ben's)
>
> advice. I am
>>
>> open
>> > to doing this in the component itself if this is the right way of
>
> handling
>>
>> this.
>> > I saw this constant being used in the status bar. At the same time
>
> bookmark
>>
>> > manager uses hard-coded values for background. I was thinking using
>
> theme for
>>
>> > the browser_view would be the right thing...
>
>> Glen knows these constants better than I. Glen?
>
>
>
> http://codereview.chromium.org/149258
>

[Glen Murphy, 2009-07-08 22:01:13]

On 2009/07/08 21:58:17, sky wrote:
> The question is, do we want to use this for the bookmark manager?

Sorry, missed that. No - dialogs are not themed.

[pfeldman, 2009-07-09 09:06:34]

On 2009/07/08 22:01:13, Glen Murphy wrote:
> On 2009/07/08 21:58:17, sky wrote:
> > The question is, do we want to use this for the bookmark manager?
> 
> Sorry, missed that. No - dialogs are not themed.

Ok, so I am submitting it this way then. Thanks!

[sky, 2009-07-09 16:01:26]

LGTM