Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 149245: Allow variable proxies for the same global variable to share the same... (Closed)

Created:
11 years, 5 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Allow variable proxies for the same global variable to share the same variable object. Add a map from names to variables for global scopes just like non-global scopes. Variables are added to the map by the parser when it encounters a declaration in a global scope or else at scope resolution time by a failed variable lookup from the global scope or an inner one and with no intervening with statements or possible calls to eval. Committed: http://code.google.com/p/v8/source/detail?r=2369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -96 lines) Patch
M src/parser.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M src/scopes.h View 5 chunks +35 lines, -23 lines 0 comments Download
M src/scopes.cc View 15 chunks +62 lines, -61 lines 0 comments Download
M src/variables.h View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 5 months ago (2009-07-07 09:08:06 UTC) #1
Kasper Lund
11 years, 5 months ago (2009-07-07 09:10:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698