Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Issue 149236: Add o3djs.DestinationBuffer to converter.... (Closed)

Created:
11 years, 5 months ago by gman
Modified:
9 years, 7 months ago
Reviewers:
apatrick
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Add o3djs.DestinationBuffer to converter. I named it o3djs.DestinationBuffer because it has nothing to do with O3D. It's purely part of our sample serialization example. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20013

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+517 lines, -53 lines) Patch
M converter/cross/converter.cc View 2 chunks +3 lines, -1 line 0 comments Download
M core/cross/object_base.h View 3 chunks +20 lines, -8 lines 0 comments Download
M core/cross/object_base.cc View 1 chunk +9 lines, -0 lines 1 comment Download
M core/cross/stream_bank.cc View 1 chunk +3 lines, -0 lines 1 comment Download
M import/build.scons View 1 chunk +1 line, -0 lines 0 comments Download
M import/cross/collada.h View 4 chunks +6 lines, -2 lines 0 comments Download
M import/cross/collada.cc View 13 chunks +116 lines, -36 lines 0 comments Download
A import/cross/destination_buffer.h View 1 chunk +83 lines, -0 lines 1 comment Download
A import/cross/destination_buffer.cc View 1 1 chunk +82 lines, -0 lines 0 comments Download
A import/cross/destination_buffer_test.cc View 1 1 chunk +104 lines, -0 lines 0 comments Download
M samples/o3djs/serialization.js View 1 chunk +14 lines, -0 lines 0 comments Download
M serializer/cross/serializer.cc View 5 chunks +31 lines, -0 lines 1 comment Download
M serializer/cross/version.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/build.scons View 5 chunks +6 lines, -5 lines 0 comments Download
M tests/selenium/tests/serialization-test.html View 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gman
Please review. Thanks.
11 years, 5 months ago (2009-07-07 00:43:04 UTC) #1
apatrick
11 years, 5 months ago (2009-07-07 00:58:25 UTC) #2
LGTM

http://codereview.chromium.org/149236/diff/38/40
File core/cross/object_base.cc (right):

http://codereview.chromium.org/149236/diff/38/40#newcode47
Line 47: const char* ObjectBase::Class::unqualified_name() const {
How about a unit test?

http://codereview.chromium.org/149236/diff/38/41
File core/cross/stream_bank.cc (right):

http://codereview.chromium.org/149236/diff/38/41#newcode94
Line 94: // data to GPU so we can only allow GPU accessable buffers through
here.
accessable -> accessible

http://codereview.chromium.org/149236/diff/38/52
File import/cross/destination_buffer.h (right):

http://codereview.chromium.org/149236/diff/38/52#newcode73
Line 73: char* buffer_;  // The actual data for this buffer.
char* -> scoped_array

http://codereview.chromium.org/149236/diff/38/47
File serializer/cross/serializer.cc (right):

http://codereview.chromium.org/149236/diff/38/47#newcode362
Line 362: Visit(static_cast<NamedObject*>(buffer));
Comment why its not the base class.

Powered by Google App Engine
This is Rietveld 408576698