Create watchlist for media changes.

Create watchlist for media changes.  The regex is pretty permissive because the media files are scattered in multiple directories with the only commonality being the word "media". (eg chrome/renderer/media, third_party/media, or more annoyingly webkit/glue/resources/media_pause.png, and webkit/api/src/WebMediaPlayerClientImpl.cpp)

[awong, 2009-07-06 23:50:55]

Does this regex seem too permissive?

[Alpha Left Google, 2009-07-06 23:54:59]

LGTM.

[awong, 2009-07-08 17:43:56]

On 2009/07/06 23:54:59, Alpha wrote:
> LGTM.

Andrew, given the mail you sent to chromium-dev about watchlists yesterday, do
you want me to try and pare down the regex a bit?  I'm inclined to leave it over
permissive at this point...

[scherkus (not reviewing), 2009-07-08 17:46:03]

yeah I'm fine leaving it as is

On Wed, Jul 8, 2009 at 10:43 AM, <ajwong@chromium.org> wrote:

> On 2009/07/06 23:54:59, Alpha wrote:
>
>> LGTM.
>>
>
> Andrew, given the mail you sent to chromium-dev about watchlists
> yesterday, do you want me to try and pare down the regex a bit?  I'm
> inclined to leave it over permissive at this point...
>
>
> http://codereview.chromium.org/149232
>

[scherkus (not reviewing), 2009-07-08 17:46:34]

mostly because we do have media subdirectories we want to watch
(/chrome/renderer/media etc...)

On Wed, Jul 8, 2009 at 10:45 AM, Andrew Scherkus <scherkus@chromium.org>wrote:

> yeah I'm fine leaving it as is
>
>
> On Wed, Jul 8, 2009 at 10:43 AM, <ajwong@chromium.org> wrote:
>
>> On 2009/07/06 23:54:59, Alpha wrote:
>>
>>> LGTM.
>>>
>>
>> Andrew, given the mail you sent to chromium-dev about watchlists
>> yesterday, do you want me to try and pare down the regex a bit?  I'm
>> inclined to leave it over permissive at this point...
>>
>>
>> http://codereview.chromium.org/149232
>>
>
>

[awong, 2009-07-08 17:47:53]

On 2009/07/08 17:46:34, scherkus wrote:
> mostly because we do have media subdirectories we want to watch
> (/chrome/renderer/media etc...)

Yeah, same thought. I tried to do it more specifically the first time, but the
regex got pretty big.  I'll add that rationale into the CL description.
 
> On Wed, Jul 8, 2009 at 10:45 AM, Andrew Scherkus <scherkus@chromium.org>wrote:
> 
> > yeah I'm fine leaving it as is
> >
> >
> > On Wed, Jul 8, 2009 at 10:43 AM, <ajwong@chromium.org> wrote:
> >
> >> On 2009/07/06 23:54:59, Alpha wrote:
> >>
> >>> LGTM.
> >>>
> >>
> >> Andrew, given the mail you sent to chromium-dev about watchlists
> >> yesterday, do you want me to try and pare down the regex a bit?  I'm
> >> inclined to leave it over permissive at this point...
> >>
> >>
> >> http://codereview.chromium.org/149232
> >>
> >
> >
>

[awong, 2009-07-08 18:04:18]

On 2009/07/08 17:47:53, awong wrote:
> On 2009/07/08 17:46:34, scherkus wrote:
> > mostly because we do have media subdirectories we want to watch
> > (/chrome/renderer/media etc...)
> 
> Yeah, same thought. I tried to do it more specifically the first time, but the
> regex got pretty big.  I'll add that rationale into the CL description.
>  
> > On Wed, Jul 8, 2009 at 10:45 AM, Andrew Scherkus
<scherkus@chromium.org>wrote:
> > 
> > > yeah I'm fine leaving it as is
> > >
> > >
> > > On Wed, Jul 8, 2009 at 10:43 AM, <ajwong@chromium.org> wrote:
> > >
> > >> On 2009/07/06 23:54:59, Alpha wrote:
> > >>
> > >>> LGTM.
> > >>>
> > >>
> > >> Andrew, given the mail you sent to chromium-dev about watchlists
> > >> yesterday, do you want me to try and pare down the regex a bit?  I'm
> > >> inclined to leave it over permissive at this point...
> > >>
> > >>
> > >> http://codereview.chromium.org/149232
> > >>
> > >
> > >
> >

Adding nimerish@ to sanity check the change before checkin.

[Nirnimesh, 2009-07-08 18:21:36]

LGTM

http://codereview.chromium.org/149232/diff/8/1006
File WATCHLISTS (right):

http://codereview.chromium.org/149232/diff/8/1006#newcode67
Line 67: 'filepath': '.*media.*|.*Media.*|^third_party/ffmpeg/.*$',
.*media.* works the same as media, so it can be written as:

'filepath': 'media|Media|^third_party/ffmpeg/'

[awong, 2009-07-08 18:23:57]

On 2009/07/08 18:21:36, Nirnimesh wrote:
> LGTM
> 
> http://codereview.chromium.org/149232/diff/8/1006
> File WATCHLISTS (right):
> 
> http://codereview.chromium.org/149232/diff/8/1006#newcode67
> Line 67: 'filepath': '.*media.*|.*Media.*|^third_party/ffmpeg/.*$',
> .*media.* works the same as media, so it can be written as:
> 
> 'filepath': 'media|Media|^third_party/ffmpeg/'

ooh. fixed. :)

Thanks!