OGG and OGV added to supported media types for omnibox, href and command line...

OGG and OGV added to supported media types for omnibox, href and command line.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20008

[fbarchard, 2009-07-06 23:49:00]

This change allows ogg and ogv to work from omnibox and ogv from command line.
This spreadsheet shows full test matrix of types, omnibox, command line and href
https://spreadsheets.google.com/a/google.com/ccc?key=0Ag1JJ1PDPcOXdHVsUlFseTB...

[fbarchard, 2009-07-06 23:49:00]

This change allows ogg and ogv to work from omnibox and ogv from command line.
This spreadsheet shows full test matrix of types, omnibox, command line and href
https://spreadsheets.google.com/a/google.com/ccc?key=0Ag1JJ1PDPcOXdHVsUlFseTB...

[awong, 2009-07-06 23:52:37]

LGTM

[hclam, 2009-07-06 23:53:12]

I also found this list: http://plugindoc.mozdev.org/winmime.php
<http://plugindoc.mozdev.org/winmime.php>Maybe it gives a more comprehensive
list?

Alpha

2009/7/6 <fbarchard@chromium.org>

> Reviewers: awong, Alpha,
>
> Message:
> This change allows ogg and ogv to work from omnibox and ogv from command
> line.
> This spreadsheet shows full test matrix of types, omnibox, command line
> and href
>
>
https://spreadsheets.google.com/a/google.com/ccc?key=0Ag1JJ1PDPcOXdHVsUlFseTB...
>
>
>
>
> Description:
> OGG and OGV added to supported media types for omnibox, href and command
> line.
>
>
> Please review this at http://codereview.chromium.org/149228
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     net/base/mime_util.cc
>
>
> Index: net/base/mime_util.cc
> ===================================================================
> --- net/base/mime_util.cc       (revision 19970)
> +++ net/base/mime_util.cc       (working copy)
> @@ -66,6 +66,11 @@
>   { "image/gif", "gif" },
>   { "image/jpeg", "jpeg,jpg" },
>   { "image/png", "png" },
> +  { "video/mp4", "mp4,m4v" },
> +  { "audio/mp4", "m4a" },
> +  { "audio/mp3", "mp3" },
> +  { "video/ogg", "ogv,ogm" },
> +  { "audio/ogg", "ogg,oga" },
>   { "application/xhtml+xml", "xhtml,xht" }
>  };
>
> @@ -169,6 +174,7 @@
>  };
>
>  // TODO(hclam): Integrate this list with |secondary_mappings| above.
> +// A list of media types:
> http://en.wikipedia.org/wiki/Internet_media_type
>  static const char* const supported_media_types[] = {
>   // Ogg.
>   "audio/ogg",
> @@ -184,6 +190,7 @@
>   // MP3.
>   // TODO(hclam): may add "audio/mpeg" and "audio/x-mp3".
>   "audio/mp3",
> +  "audio/x-mp3",
>
>   // AAC.
>   "audio/aac",
>
>
>

[fbarchard, 2009-07-07 00:20:39]

Added link to comprehensive mimetypes.
Removed TODO and ambiguous mpeg mimetypes

[Alpha Left Google, 2009-07-07 00:47:21]

LGTM with tiny nit.

http://codereview.chromium.org/149228/diff/1005/1006
File net/base/mime_util.cc (right):

http://codereview.chromium.org/149228/diff/1005/1006#newcode177
Line 177: // A comprehensive mime type list: 
http://plugindoc.mozdev.org/winmime.php
nit: only one space after colon