Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5717)

Unified Diff: chrome/browser/renderer_host/resource_message_filter.cc

Issue 149212: Move printing related stuff to the root printing project from the browser pro... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/renderer_host/resource_message_filter.cc
===================================================================
--- chrome/browser/renderer_host/resource_message_filter.cc (revision 20026)
+++ chrome/browser/renderer_host/resource_message_filter.cc (working copy)
@@ -113,6 +113,27 @@
scoped_ptr<Clipboard::ObjectMap> objects_;
};
+void RenderParamsFromPrintSettings(const printing::PrintSettings& settings,
+ ViewMsg_Print_Params* params) {
+ DCHECK(params);
+#if defined(OS_WIN)
M-A Ruel 2009/07/09 19:27:59 Actually, why OS_WIN? I don't see much platform sp
Sverrir 2009/07/09 20:13:23 Currently this file is including the temp_scaffold
+ params->printable_size.SetSize(
+ settings.page_setup_pixels().content_area().width(),
+ settings.page_setup_pixels().content_area().height());
+ params->dpi = settings.dpi();
+ // Currently hardcoded at 1.25. See PrintSettings' constructor.
+ params->min_shrink = settings.min_shrink;
+ // Currently hardcoded at 2.0. See PrintSettings' constructor.
+ params->max_shrink = settings.max_shrink;
+ // Currently hardcoded at 72dpi. See PrintSettings' constructor.
+ params->desired_dpi = settings.desired_dpi;
+ // Always use an invalid cookie.
+ params->document_cookie = 0;
+ params->selection_only = settings.selection_only;
+#else
+ NOTIMPLEMENTED();
+#endif
+}
} // namespace
@@ -724,7 +745,7 @@
if (printer_query->last_status() != printing::PrintingContext::OK) {
memset(&params, 0, sizeof(params));
} else {
- printer_query->settings().RenderParams(&params);
+ RenderParamsFromPrintSettings(printer_query->settings(), &params);
params.document_cookie = printer_query->cookie();
}
ViewHostMsg_GetDefaultPrintSettings::WriteReplyParams(reply_msg, params);
@@ -781,7 +802,7 @@
!printer_query->settings().dpi()) {
memset(&params, 0, sizeof(params));
} else {
- printer_query->settings().RenderParams(&params.params);
+ RenderParamsFromPrintSettings(printer_query->settings(), &params.params);
params.params.document_cookie = printer_query->cookie();
params.pages =
printing::PageRange::GetPages(printer_query->settings().ranges);

Powered by Google App Engine
This is Rietveld 408576698