Whenever proxy configurations contain socks and http/https/ftp proxies, socks...

net/proxy/proxy_config_service_linux.cc

Index: net/proxy/proxy_config_service_linux.cc
===================================================================
--- net/proxy/proxy_config_service_linux.cc	(revision 20189)
+++ net/proxy/proxy_config_service_linux.cc	(working copy)
@@ -94,7 +94,8 @@
   if (env_var_getter_->Getenv(variable, &env_value)) {
     if (!env_value.empty()) {
       env_value = FixupProxyHostScheme(scheme, env_value);
-      ProxyServer proxy_server = ProxyServer::FromURI(env_value);
+      ProxyServer proxy_server =
+          ProxyServer::FromURI(env_value, ProxyServer::SCHEME_HTTP);
       if (proxy_server.is_valid() && !proxy_server.is_direct()) {
         *result_server = proxy_server;
         return true;
@@ -386,7 +387,9 @@
   host = FixupProxyHostScheme(
       is_socks ? ProxyServer::SCHEME_SOCKS4 : ProxyServer::SCHEME_HTTP,
       host);
-  ProxyServer proxy_server = ProxyServer::FromURI(host);
+  // TODO(arindam): verify on linux

[eroman, 2009/07/10 21:24:46]

what is this todo about? this looks good to me.

you may want to instead add a TODO about cleaning-up "FixupProxyHostScheme()" --
now that we have the default_scheme parameter, there is no need for it to be
manipulating the URI strings.

[Arindam, 2009/07/11 00:53:35]

It was a legacy comment, I guess.
Done.

+  ProxyServer proxy_server = ProxyServer::FromURI(host,
+                                                  ProxyServer::SCHEME_HTTP);
   if (proxy_server.is_valid()) {
     *result_server = proxy_server;
     return true;