Whenever proxy configurations contain socks and http/https/ftp proxies, socks...

net/proxy/proxy_config_service_linux.cc

 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/proxy/proxy_config_service_linux.h"
 
 #include <gconf/gconf-client.h>
 #include <stdlib.h>
 
 #include "base/logging.h"
@@ skipping 76 matching lines @@
 
 }  // namespace
 
 bool ProxyConfigServiceLinux::Delegate::GetProxyFromEnvVarForScheme(
     const char* variable, ProxyServer::Scheme scheme,
     ProxyServer* result_server) {
   std::string env_value;
   if (env_var_getter_->Getenv(variable, &env_value)) {
     if (!env_value.empty()) {
       env_value = FixupProxyHostScheme(scheme, env_value);
-      ProxyServer proxy_server = ProxyServer::FromURI(env_value);
+      ProxyServer proxy_server =
+          ProxyServer::FromURI(env_value, ProxyServer::SCHEME_HTTP);
       if (proxy_server.is_valid() && !proxy_server.is_direct()) {
         *result_server = proxy_server;
         return true;
       } else {
         LOG(ERROR) << "Failed to parse environment variable " << variable;
       }
     }
   }
   return false;
 }
@@ skipping 271 matching lines @@
   // Check for an optional port.
   int port;
   gconf_getter_->GetInt((key + "port").c_str(), &port);
   if (port != 0) {
     // If a port is set and non-zero:
     host += ":" + IntToString(port);
   }
   host = FixupProxyHostScheme(
       is_socks ? ProxyServer::SCHEME_SOCKS4 : ProxyServer::SCHEME_HTTP,
       host);
-  ProxyServer proxy_server = ProxyServer::FromURI(host);
+  // TODO(arindam): verify on linux

[eroman, 2009/07/10 21:24:46]

what is this todo about? this looks good to me.

you may want to instead add a TODO about cleaning-up "FixupProxyHostScheme()" --
now that we have the default_scheme parameter, there is no need for it to be
manipulating the URI strings.

[Arindam, 2009/07/11 00:53:35]

It was a legacy comment, I guess.
Done.

+  ProxyServer proxy_server = ProxyServer::FromURI(host,
+                                                  ProxyServer::SCHEME_HTTP);
   if (proxy_server.is_valid()) {
     *result_server = proxy_server;
     return true;
   }
   return false;
 }
 
 bool ProxyConfigServiceLinux::Delegate::GetConfigFromGConf(
     ProxyConfig* config) {
   std::string mode;
@@ skipping 252 matching lines @@
                              new GConfSettingGetterImpl())) {
 }
 
 ProxyConfigServiceLinux::ProxyConfigServiceLinux(
     EnvironmentVariableGetter* env_var_getter,
     GConfSettingGetter* gconf_getter)
     : delegate_(new Delegate(env_var_getter, gconf_getter)) {
 }
 
 }  // namespace net