Issue 149161: Move extension install to after .crx download completes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 149161: Move extension install to after .crx download completes (Closed)

Created:
11 years, 5 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Matt Perry

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Move extension install to after .crx download completes This was resulting in some situations where we attempted to unpack the .crx while its file was still in use by the download manager. BUG=15881 R=mpcomplete Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=20083

Patch Set 1 #

Total comments: 1

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -4 lines)			Patch
	M	chrome/browser/download/download_manager.cc	View		2 chunks	+1 line, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Matt Perry

http://codereview.chromium.org/149161/diff/1/2 File chrome/browser/download/download_manager.cc (right): http://codereview.chromium.org/149161/diff/1/2#newcode841 Line 841: OpenChromeExtension(download->full_path()); Are you sure this happens after DownloadRenamedToFinalName? ...

11 years, 5 months ago (2009-07-02 23:52:01 UTC) #2

lgtm

Expand Messages | Collapse Messages