Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1685)

Unified Diff: chrome/browser/download/download_manager.cc

Issue 149161: Move extension install to after .crx download completes (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_manager.cc
diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc
index 7cceb9e52b3f7a5e3211221922607fde57fbfb7e..2f3497e430a79650e0ba376f084fee9523b3c97f 100644
--- a/chrome/browser/download/download_manager.cc
+++ b/chrome/browser/download/download_manager.cc
@@ -820,8 +820,6 @@ void DownloadManager::DownloadFinished(int32 download_id, int64 size) {
void DownloadManager::DownloadRenamedToFinalName(int download_id,
const FilePath& full_path) {
- if (Extension::IsExtension(full_path))
- OpenChromeExtension(full_path);
}
void DownloadManager::ContinueDownloadFinished(DownloadItem* download) {
@@ -840,8 +838,7 @@ void DownloadManager::ContinueDownloadFinished(DownloadItem* download) {
// Handle chrome extensions explicitly and skip the shell execute.
if (Extension::IsExtension(download->full_path())) {
- // Skip the shell execute. This will be handled in
- // DownloadRenamedToFinalName
+ OpenChromeExtension(download->full_path());
Matt Perry 2009/07/02 23:52:01 Are you sure this happens after DownloadRenamedToF
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698