Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 149094: Removes our homespun grow box and replaces it with the... (Closed)

Created:
11 years, 6 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Removes our homespun grow box and replaces it with the standard widget. This may also fix some of our resizing issues. BUG=http://crbug.com/14663 TEST=The resizer widget should still work as expected. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19501

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -101 lines) Patch
M chrome/app/nibs/en.lproj/BrowserWindow.xib View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/app/nibs/en.lproj/TabContents.xib View 1 7 chunks +4 lines, -27 lines 0 comments Download
M chrome/browser/cocoa/browser_window_controller.mm View 1 4 chunks +30 lines, -12 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.h View 1 3 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/cocoa/tab_contents_controller.mm View 1 1 chunk +0 lines, -25 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.h View 1 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 1 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller_unittest.mm View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rohitrao (ping after 24h)
This actually does the right thing when the download shelf is open, in that the ...
11 years, 6 months ago (2009-06-26 18:42:26 UTC) #1
pink (ping after 24hrs)
LGTM with 2 nib questions. This rocks, btw! http://codereview.chromium.org/149094/diff/1/3 File chrome/app/nibs/en.lproj/BrowserWindow.xib (right): http://codereview.chromium.org/149094/diff/1/3#newcode39 Line 39: ...
11 years, 5 months ago (2009-06-29 14:39:44 UTC) #2
pink (ping after 24hrs)
do you also want to svn remove grow_box_view.*?
11 years, 5 months ago (2009-06-29 14:40:20 UTC) #3
rohitrao (ping after 24h)
I'll svn rm the growbox files when I move this CL over to my read/write ...
11 years, 5 months ago (2009-06-29 15:59:44 UTC) #4
pink (ping after 24hrs)
11 years, 5 months ago (2009-06-29 17:07:55 UTC) #5
Still LGTM

Powered by Google App Engine
This is Rietveld 408576698