Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 147232: Corrects RWHVCocoa to convert from flipped to unflipped... (Closed)

Created:
11 years, 6 months ago by rohitrao (ping after 24h)
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), Ben Goodger (Google)
Visibility:
Public.

Description

Corrects RWHVCocoa to convert from flipped to unflipped coordinates before whiting out unpainted areas. BUG=None TEST=Resize newly-created window, check for black areas. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19535

Patch Set 1 #

Total comments: 6

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -11 lines) Patch
M chrome/browser/renderer_host/render_widget_host_view_mac.mm View 1 1 chunk +34 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rohitrao (ping after 24h)
There's some extra code in here because gfx::Rect was crashing on negative widths. I ended ...
11 years, 5 months ago (2009-06-29 16:24:35 UTC) #1
pink (ping after 24hrs)
LGTM http://codereview.chromium.org/147232/diff/1/2 File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right): http://codereview.chromium.org/147232/diff/1/2#newcode455 Line 455: int width = damaged_rect.right() - x; why ...
11 years, 5 months ago (2009-06-29 16:49:09 UTC) #2
Avi (use Gerrit)
lg
11 years, 5 months ago (2009-06-29 16:53:57 UTC) #3
rohitrao (ping after 24h)
11 years, 5 months ago (2009-06-29 21:26:17 UTC) #4
http://codereview.chromium.org/147232/diff/1/2
File chrome/browser/renderer_host/render_widget_host_view_mac.mm (right):

http://codereview.chromium.org/147232/diff/1/2#newcode455
Line 455: int width = damaged_rect.right() - x;
On 2009/06/29 16:49:09, pink wrote:
> why not just use std::abs? or am i not following?

If the width or height are negative, I need to adjust the origin x or y
accordingly.

http://codereview.chromium.org/147232/diff/1/2#newcode464
Line 464: 
On 2009/06/29 16:49:09, pink wrote:
> omit blank line

Done.

http://codereview.chromium.org/147232/diff/1/2#newcode486
Line 486: 
On 2009/06/29 16:49:09, pink wrote:
> omit blank line

Done.

Powered by Google App Engine
This is Rietveld 408576698