Teach tools/valgrind about the output directory used by the Make build.

Teach the valgrind and layout tests about the output directory used by the Make build on Linux
BUG=http://crbug.com/15454
TEST=export GYP_GENERATORS=make; rm -rf sconsbuild; gclient runhooks --force; make -r base_unittests layout_tests; sh tools/valgrind/chrome_tests.sh -t base_unittests; verify that it finds and runs base_unittests; same thing with -t layout_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19453

[dank, 2009-06-26 16:50:08]

One less roadblock to engineers running valgrind tests on their
linux boxes.

[Evan Martin, 2009-06-26 17:01:56]

LGTM
if it really works (the typo I mention indicates maybe that code path isn't
getting exercised?)

BTW, I can't send you reviews since you have two "dank"s registered on this
site.  To work around this, I suggest logging in with your gmail address and
changing your nick to something like "the wrong dank to send reviews to".

http://codereview.chromium.org/147209/diff/4/1001
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/147209/diff/4/1001#newcode49
Line 49: newest_dir = the_dir
the_dir -- typo?

http://codereview.chromium.org/147209/diff/4/1001#newcode53
Line 53: if not os.path.isfile(file2):
it seems you have 3-space tabs (?)

http://codereview.chromium.org/147209/diff/4/1001#newcode132
Line 132: #os.path.join(module_dir, "Debug")
I'd just delete it, then.

[Evan Martin, 2009-06-26 19:09:55]

LGTM

(I repeat my prior plea about fixing your rietveld nick)

http://codereview.chromium.org/147209/diff/1004/6
File tools/valgrind/chrome_tests.py (right):

http://codereview.chromium.org/147209/diff/1004/6#newcode67
Line 67: if (newest_dir == None):
no parens on if statements in python