Teach tools/valgrind about the output directory used by the Make build.

tools/valgrind/chrome_tests.py

 #!/usr/bin/python
 # Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 # chrome_tests.py
 
 ''' Runs various chrome tests through valgrind_test.py.
 
 This file is a copy of ../purify/chrome_tests.py. Eventually, it would be nice
@@ skipping 17 matching lines @@
 # TODO(erg): Copy/Move the relevant functions from the layout_package version
 # of platform_utils back up to google.platform_utils
 # package. http://crbug.com/6164
 import layout_package.platform_utils
 
 import common
 
 
 class TestNotFound(Exception): pass
 
+def Dir2IsNewer(dir1, dir2):
+  if dir2 == None or not os.path.isdir(dir2):
+    return False
+  if dir1 == None or not os.path.isdir(dir1):
+    return True
+  return (os.stat(dir2)[stat.ST_MTIME] - os.stat(dir1)[stat.ST_MTIME]) > 0
+
+def FindNewestDir(dirs):
+  newest_dir = None
+  for dir in dirs:
+    if Dir2IsNewer(newest_dir, dir):
+      newest_dir = dir
+  return newest_dir
+
+def File2IsNewer(file1, file2):
+  if file2 == None or not os.path.isfile(file2):
+    return False
+  if file1 == None or not os.path.isfile(file1):
+    return True
+  return (os.stat(file2)[stat.ST_MTIME] - os.stat(file1)[stat.ST_MTIME]) > 0
+
+def FindDirContainingNewestFile(dirs, file):
+  newest_dir = None
+  newest_file = None
+  for dir in dirs:
+    the_file = os.path.join(dir, file)
+    if File2IsNewer(newest_file, the_file):
+      newest_dir = dir
+      newest_file = the_file
+  if newest_dir == None:
+    logging.error("cannot find file %s anywhere, have you built it?" % file)
+    sys.exit(-1)
+  return newest_dir
 
 class ChromeTests:
   '''This class is derived from the chrome_tests.py file in ../purify/.
   '''
 
   def __init__(self, options, args, test):
     # The known list of tests.
     # Recognise the original abbreviations as well as full executable names.
     self._test_list = {
       "base": self.TestBase,            "base_unittests": self.TestBase,
@@ skipping 39 matching lines @@
     self._data_dirs = [google.path_utils.ScriptDir()]
 
     if module == "chrome":
       # unfortunately, not all modules have the same directory structure
       self._data_dirs.append(os.path.join(module_dir, "test", "data",
                                           "valgrind"))
     else:
       self._data_dirs.append(os.path.join(module_dir, "data", "valgrind"))
 
     if not self._options.build_dir:
-      builddir = {
-        'darwin': 'xcodebuild',
-        'linux2': 'sconsbuild'
-      }[sys.platform]
-      dir_chrome = os.path.join(self._source_dir, builddir, "Debug")
-      dir_module = os.path.join(module_dir, "Debug")
+      dirs = [
+        os.path.join(self._source_dir, "xcodebuild", "Debug"),
+        os.path.join(self._source_dir, "sconsbuild", "Debug"),
+        os.path.join(self._source_dir, "out", "Debug"),
+      ]
       if exe:
-        exe_chrome = os.path.join(dir_chrome, exe)
-        exe_module = os.path.join(dir_module, exe)
-        if os.path.isfile(exe_chrome) and not os.path.isfile(exe_module):
-          self._options.build_dir = dir_chrome
-        elif os.path.isfile(exe_module) and not os.path.isfile(exe_chrome):
-          self._options.build_dir = dir_module
-        elif (os.stat(exe_module)[stat.ST_MTIME] >
-              os.stat(exe_chrome)[stat.ST_MTIME]):
-          self._options.build_dir = dir_module
-        else:
-          self._options.build_dir = dir_chrome
+        self._options.build_dir = FindDirContainingNewestFile(dirs, exe)
       else:
-        if os.path.isdir(dir_chrome) and not os.path.isdir(dir_module):
-          self._options.build_dir = dir_chrome
-        elif os.path.isdir(dir_module) and not os.path.isdir(dir_chrome):
-          self._options.build_dir = dir_module
-        elif (os.stat(dir_module)[stat.ST_MTIME] >
-              os.stat(dir_chrome)[stat.ST_MTIME]):
-          self._options.build_dir = dir_module
-        else:
-          self._options.build_dir = dir_chrome
+        self._options.build_dir = FindNewestDir(dirs)
 
     cmd = list(self._command_preamble)
     for directory in self._data_dirs:
       suppression_file = os.path.join(directory, "suppressions.txt")
       if os.path.exists(suppression_file):
         cmd.append("--suppressions=%s" % suppression_file)
       # Platform specific suppression
       suppression_platform = {
         'darwin': 'mac',
         'linux2': 'linux'
@@ skipping 263 matching lines @@
   for t in options.test:
     tests = ChromeTests(options, args, t)
     ret = tests.Run()
     if ret: return ret
   return 0
 
 
 if __name__ == "__main__":
   ret = _main(sys.argv)
   sys.exit(ret)