Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 147192: Updates the o3dConverter to turn on filtering by default... (Closed)

Created:
11 years, 6 months ago by gman
Modified:
9 years, 7 months ago
Reviewers:
apatrick
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Updates the o3dConverter to turn on filtering by default because the collada exporters often set it to NONE or POINT. Also make it change any collada standard Material that is used by a Primitive with no normals to use "constant" shading. This should make sketchup stuff work. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19545

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+180 lines, -36 lines) Patch
M converter/cross/converter.h View 2 chunks +11 lines, -1 line 1 comment Download
M converter/cross/converter.cc View 1 chunk +72 lines, -0 lines 2 comments Download
M converter/cross/converter_main.cc View 1 chunk +18 lines, -3 lines 0 comments Download
M import/cross/collada.h View 1 chunk +25 lines, -0 lines 0 comments Download
M import/cross/collada.cc View 19 chunks +54 lines, -32 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gman
11 years, 6 months ago (2009-06-26 03:49:55 UTC) #1
apatrick
11 years, 6 months ago (2009-06-26 20:04:29 UTC) #2
LGTM

http://codereview.chromium.org/147192/diff/1/2
File converter/cross/converter.cc (right):

http://codereview.chromium.org/147192/diff/1/2#newcode140
Line 140: sampler->set_mag_filter(Sampler::ANISOTROPIC);
Sampler::LINEAR?

http://codereview.chromium.org/147192/diff/1/2#newcode171
Line 171: // 4) DiffuseSamer -> EmissiveSampler
DiffuseSamer->DiffuseSampler

http://codereview.chromium.org/147192/diff/1/3
File converter/cross/converter.h (right):

http://codereview.chromium.org/147192/diff/1/3#newcode78
Line 78: // Tells the covnerter not to change materials to constant if they are
used
covnerter -> converter

Powered by Google App Engine
This is Rietveld 408576698