Use C99 standard format macros for 64-bit values.

Use C99 standard format macros for 64-bit values.

Currently we have several uses of %I64d in format strings to indicate
a 64-bit value. This does not work on Mac or Linux, where 'I'
indicates the use of locale specific digits.

Instead, we introduce base/format_macros.h which mimic the C99
standard macros for 64-bit values in a cross-platform manner.

[Evan Martin, 2009-06-25 17:46:35]

+spec nazis  (i kid because i love)

http://codereview.chromium.org/147154/diff/1007/10
File chrome/chrome.gyp (right):

http://codereview.chromium.org/147154/diff/1007/10#newcode44
Line 44: '__STDC_FORMAT_MACROS',
comment on this?  (just a reference to the new header would be good)

[Mark Mentovai, 2009-06-25 18:02:17]

http://codereview.chromium.org/147154/diff/1007/8
File base/format_macros.h (right):

http://codereview.chromium.org/147154/diff/1007/8#newcode21
Line 21: #if defined(_INTTYPES_H) && !defined(PRId64)
There's no standard for system header guards - this doesn't match the guard
style used on Mac OS X.

http://codereview.chromium.org/147154/diff/1007/10
File chrome/chrome.gyp (right):

http://codereview.chromium.org/147154/diff/1007/10#newcode44
Line 44: '__STDC_FORMAT_MACROS',
Evan Martin wrote:
> comment on this?  (just a reference to the new header would be good)

Why do we need to define this here *and* in the new header?  If we can get away
with having it defined globally, then we should just define it here.

[Dean McNamee, 2009-06-25 20:21:37]

We went through all of this with V8 and decided using the header was not the
best thing to do.

Look at v8 globals.h, basically they just defined their own macros based on the
platform.  I can give you more of the background if you need it, but that's
probably what I would do for Chrome as well.