base/trace_event.cc - Issue 147154: Use C99 standard format macros for 64-bit values. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1438)

My Issues | Starred Open | Closed | All

Unified Diff: base/trace_event.cc

Issue 147154: Use C99 standard format macros for 64-bit values. (Closed)

Patch Set: ... Created 11 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« base/format_macros.h ('K') | « base/format_macros.h ('k') | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: base/trace_event.cc

diff --git a/base/trace_event.cc b/base/trace_event.cc

index ccac825b80400a5f4c950432d776a0d72bdf60a3..6c79825f866c2e8d94f917e015580aab5430f2c3 100644

--- a/base/trace_event.cc

+++ b/base/trace_event.cc

@@ -4,6 +4,7 @@

#include "base/trace_event.h"

+#include "base/format_macros.h"

#include "base/file_path.h"

#include "base/file_util.h"

#include "base/path_service.h"

@@ -132,7 +133,7 @@ void TraceLog::Trace(const std::string& name,

std::string msg =

StringPrintf("{'pid':'0x%lx', 'tid':'0x%lx', 'type':'%s', "

"'name':'%s', 'id':'0x%lx', 'extra':'%s', 'file':'%s', "

- "'line_number':'%d', 'usec_begin': %I64d},\n",

+ "'line_number':'%d', 'usec_begin': %" PRId64 "},\n",

base::GetCurrentProcId(),

PlatformThread::CurrentId(),

kEventTypeNames[type],

« base/format_macros.h ('K') | « base/format_macros.h ('k') | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')

Powered by Google App Engine

This is Rietveld 408576698