Issue 147141: X64 implementation: VisitUnaryOperation, configure dtoa for X64 platform.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147141: X64 implementation: VisitUnaryOperation, configure dtoa for X64 platform. (Closed)

Created:
11 years, 6 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Lasse Reichstein

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

X64 implementation: VisitUnaryOperation, configure dtoa for X64 platform. Committed: http://code.google.com/p/v8/source/detail?r=2268

Patch Set 2 : '' #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -2 lines)			Patch
M	src/dtoa-config.c	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View	1	1 chunk	+156 lines, -2 lines	0 comments	Download
M	src/x64/virtual-frame-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/x64/virtual-frame-x64.cc	View		1 chunk	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein

LGTM http://codereview.chromium.org/147141/diff/1/4 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/147141/diff/1/4#newcode1565 Line 1565: __ and_(answer.reg(), Immediate(~kSmiTagMask)); Use xor_(answer.reg(), Immediate(~kSmiTagMask)) instead. ...

11 years, 6 months ago (2009-06-25 09:32:44 UTC) #2

Fixed.

Expand Messages | Collapse Messages

Issue 147141: X64 implementation: VisitUnaryOperation, configure dtoa for X64 platform. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages