Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 147129: Adding in most of the unit tests. (Closed)

Created:
11 years, 6 months ago by Greg Spencer
Modified:
9 years, 7 months ago
Reviewers:
vangelis
CC:
o3d-review_googlegroups.com
Visibility:
Public.

Description

Adding in most of the unit tests. This adds 406 of our unit tests into the gyp build. 21 of them fail, but that is only because they don't have test input yet -- I haven't added the build code that copies the test inputs into the build dir yet. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19778

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 6

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -113 lines) Patch
M build/all.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M build/nacl.gyp View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M core/core.gyp View 1 2 3 3 chunks +62 lines, -57 lines 0 comments Download
M core/win/d3d9/effect_d3d9.cc View 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M import/cross/memory_stream_test.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M import/import.gyp View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
M plugin/plugin.gyp View 1 2 3 2 chunks +12 lines, -6 lines 0 comments Download
M plugin/win/main_win.cc View 2 3 1 chunk +1 line, -1 line 0 comments Download
M serializer/serializer.gyp View 1 2 3 1 chunk +8 lines, -3 lines 0 comments Download
M statsreport/statsreport.gyp View 1 2 3 1 chunk +29 lines, -24 lines 0 comments Download
M tests/build.scons View 1 2 3 1 chunk +6 lines, -6 lines 0 comments Download
M tests/common/win/testing_common.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M utils/utils.gyp View 1 2 3 1 chunk +13 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Greg Spencer
11 years, 5 months ago (2009-06-30 17:26:57 UTC) #1
vangelis
Don't know much about GYP but changes look reasonable. Just some comments inline on things ...
11 years, 5 months ago (2009-07-01 17:03:23 UTC) #2
Greg Spencer
http://codereview.chromium.org/147129/diff/2009/2012 File plugin/plugin.gyp (right): http://codereview.chromium.org/147129/diff/2009/2012#newcode111 Line 111: '../../<(cgdir)/lib/cg.lib', On 2009/07/01 17:03:23, vangelis wrote: > Do ...
11 years, 5 months ago (2009-07-01 19:25:13 UTC) #3
vangelis
11 years, 5 months ago (2009-07-01 21:48:47 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698