Adding in most of the unit tests.

core/win/d3d9/effect_d3d9.cc

 /*
  * Copyright 2009, Google Inc.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 236 matching lines @@
 
   virtual void SetEffectParam(RendererD3D9* renderer, ID3DXEffect* d3d_effect) {
     ParamArray* param = param_->value();
     if (param) {
       unsigned size = param->size();
       if (size != sampler_unit_index_arrays_.size()) {
         O3D_ERROR(param->service_locator())
             << "number of params in ParamArray does not match number of params "
             << "needed by shader array";
       } else {
-        for (int i = 0; i < size; ++i) {
+        for (unsigned i = 0; i < size; ++i) {
           SamplerUnitIndexArray& index_array = sampler_unit_index_arrays_[i];
           Param* untyped_element = param->GetUntypedParam(i);
           // TODO(gman): Make this check happen when building the param cache.
           //    To do that would require that ParamParamArray mark it's owner
           //    as changed if a Param in it's ParamArray changes.
           if (untyped_element->IsA(ParamSampler::GetApparentClass())) {
             D3DXHANDLE dx_element =
                 d3d_effect->GetParameterElement(phandle_,  i);
             // Find the texture associated with the sampler first.
             Sampler* sampler =
@@ skipping 22 matching lines @@
   }
 
   // Resets the value of the parameter to default.  Currently this is used
   // to unbind textures contained in Sampler params.
   virtual void ResetEffectParam(RendererD3D9* renderer,
                                 ID3DXEffect* d3d_effect) {
     ParamArray* param = param_->value();
     if (param) {
       unsigned size = param->size();
       if (size == sampler_unit_index_arrays_.size()) {
-        for (int i = 0; i < size; ++i) {
+        for (unsigned i = 0; i < size; ++i) {
           SamplerUnitIndexArray& index_array = sampler_unit_index_arrays_[i];
           Param* untyped_element = param->GetUntypedParam(i);
           // TODO(gman): Make this check happen when building the param cache.
           //    To do that would require that ParamParamArray mark it's owner
           //    as changed if a Param in it's ParamArray changes.
           if (untyped_element->IsA(ParamSampler::GetApparentClass())) {
             D3DXHANDLE dx_element =
                 d3d_effect->GetParameterElement(phandle_,  i);
             // Find the texture associated with the sampler first.
             Sampler* sampler =
@@ skipping 903 matching lines @@
 // Handler for reset device. This restores the effect after a device reset.
 // Returns true on success.
 bool EffectD3D9::OnResetDevice() {
   if (d3dx_effect_)
     return HR(d3dx_effect_->OnResetDevice());
   else
     return true;
 }
 
 }  // namespace o3d