Issue 146112: Allow layout tests to be located both in src/webkit/data/layout_tests and...

Issue 146112: Allow layout tests to be located both in src/webkit/data/layout_tests and... (Closed)

Created:
11 years, 6 months ago by Victor Wang

Modified:
9 years, 7 months ago

Reviewers:
dglazkov

CC:
chromium-reviews_googlegroups.com, darin (slow to review), M-A Ruel, ojan

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Allow layout tests to be located both in src/webkit/data/layout_tests and third_party/WebKit. For tests in LayoutTests directory, the script checks whether the LayoutTests directory exists in webkit/data/layout_tests, if not, assume it is in third_party/WebKit. Basically, this patch = http_server change + Dimitri Glazkov's patch (http://codereview.chromium.org/115302). BUG=8765 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=19590

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -24 lines)			Patch
M	webkit/tools/layout_tests/layout_package/compare_failures_unittest.py	View		13 chunks	+13 lines, -13 lines	0 comments	Download
M	webkit/tools/layout_tests/layout_package/http_server.py	View	1	1 chunk	+7 lines, -1 line	0 comments	Download
M	webkit/tools/layout_tests/layout_package/path_utils.py	View	1	4 chunks	+24 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/layout_package/platform_utils_win.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/layout_tests/layout_package/test_expectations.py	View	1	2 chunks	+4 lines, -2 lines	0 comments	Download
M	webkit/tools/layout_tests/rebaseline.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/layout_tests/run_webkit_tests.py	View	1	3 chunks	+5 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

dglazkov

Can you make sure this works with all build bot combinations, such as --part X:Y, ...

11 years, 6 months ago (2009-06-25 18:24:35 UTC) #2

Victor Wang

On 2009/06/25 18:24:35, Dimitri Glazkov wrote: > Can you make sure this works with all ...

11 years, 5 months ago (2009-06-29 20:57:20 UTC) #4

Victor Wang

11 years, 5 months ago (2009-06-29 21:44:18 UTC) #5

More code that should replace LayoutDataDir with LayoutTestsDir. Patch updated,
please take a look.

On 2009/06/29 20:57:20, Victor Wang wrote:
> On 2009/06/25 18:24:35, Dimitri Glazkov wrote:
> > Can you make sure this works with all build bot combinations, such as --part
> > X:Y, etc.?
> 
> Don't see problem running with --run-chunk and --run-part.

Expand Messages | Collapse Messages