Allow layout tests to be located both in src/webkit/data/layout_tests and thi...

Allow layout tests to be located both in src/webkit/data/layout_tests and third_party/WebKit.

R=maruel
BUG=8765

[M-A Ruel, 2009-05-13 16:19:20]

http://codereview.chromium.org/115302/diff/1/4
File webkit/tools/layout_tests/layout_package/path_utils.py (right):

http://codereview.chromium.org/115302/diff/1/4#newcode57
Line 57: the specified path prefix. If the path starts with LayoutTests, checks
to see
The doc is unclear and wrong.

http://codereview.chromium.org/115302/diff/1/3
File webkit/tools/layout_tests/layout_package/test_expectations.py (right):

http://codereview.chromium.org/115302/diff/1/3#newcode315
Line 315: full_path = os.path.join(path_utils.LayoutTestsDir(test_list_path),
test_list_path)
80 cols

http://codereview.chromium.org/115302/diff/1/3#newcode364
Line 364: path = os.path.join(path_utils.LayoutTestsDir(test_list_path),
test_list_path)
80 cols

[dglazkov, 2009-05-13 16:31:54]

Thank you for reviewing. Another snapshot is ready when you are :)

http://codereview.chromium.org/115302/diff/1/4
File webkit/tools/layout_tests/layout_package/path_utils.py (right):

http://codereview.chromium.org/115302/diff/1/4#newcode57
Line 57: the specified path prefix. If the path starts with LayoutTests, checks
to see
Thanks, fixed.

http://codereview.chromium.org/115302/diff/1/3
File webkit/tools/layout_tests/layout_package/test_expectations.py (right):

http://codereview.chromium.org/115302/diff/1/3#newcode315
Line 315: full_path = os.path.join(path_utils.LayoutTestsDir(test_list_path),
test_list_path)
On 2009/05/13 16:19:20, M-A wrote:
> 80 cols

Done.

http://codereview.chromium.org/115302/diff/1/3#newcode364
Line 364: path = os.path.join(path_utils.LayoutTestsDir(test_list_path),
test_list_path)
On 2009/05/13 16:19:20, M-A wrote:
> 80 cols

Done.

[M-A Ruel, 2009-05-13 16:36:37]

lgtm

[dglazkov, 2009-05-13 21:26:51]

Adding Ojan (just in case). Can you look/see?

[ojan, 2009-05-14 04:40:12]

LGTM

[dglazkov, 2009-05-14 17:30:22]

Well, it turns out I can't do it this way. The HTTP server implicitly relies on
all tests to be in the same directory. I am investigating how I could
potentially change this without breaking things :)