Issue 14422: Introduced a TempAssign utility because I just couldn't watch this anymore. Y...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14422: Introduced a TempAssign utility because I just couldn't watch this anymore. Y... (Closed)

Created:
12 years ago by olehougaard

Modified:
9 years, 7 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Introduced a TempAssign utility because I just couldn't watch this anymore. YMMV. Committed: http://code.google.com/p/v8/source/detail?r=976

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -8 lines)			Patch
	M	src/codegen-ia32.cc	View		2 chunks	+6 lines, -8 lines	0 comments	Download
	M	src/utils.h	View		1 chunk	+17 lines, -0 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

12 years ago (2008-12-15 08:36:30 UTC) #2

LGTM

http://codereview.chromium.org/14422/diff/1/2
File src/utils.h (right):

http://codereview.chromium.org/14422/diff/1/2#newcode376
Line 376: // construction and resets it the value on destruction.
it the -> the

Expand Messages | Collapse Messages