Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(879)

Issue 1442001: GTK: Turn on the GTK+ integration by default. (Closed)

Created:
10 years, 9 months ago by Elliot Glaysher
Modified:
9 years, 7 months ago
CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

GTK: Turn on the GTK+ integration by default. This will regress default startup time for users by 50ms. This doesn't matter because this is what the users want--I've lost count of the number bloggers, people on twitter, and people in our IRC channel complaining about the lack of GTK+ integration...when it's just not on by default. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42804

Patch Set 1 #

Patch Set 2 : Only use gtk in gnome/xfce by default #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -2 lines) Patch
M base/linux_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/linux_util.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.cc View 2 chunks +16 lines, -0 lines 1 comment Download
M chrome/browser/gtk/options/advanced_contents_gtk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/profile.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/data/profiles/chrome_prefs/Preferences View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/profiles/custom_frame/Default/Preferences View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/profiles/sample/Preferences View 1 chunk +8 lines, -1 line 0 comments Download
M chrome/test/data/profiles/typical_history/Default/Preferences View 1 chunk +5 lines, -0 lines 0 comments Download
M net/proxy/proxy_config_service_linux.cc View 1 chunk +1 line, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Elliot Glaysher
10 years, 9 months ago (2010-03-26 18:31:30 UTC) #1
Evan Stade
it seems this should be a per-DE default, like the window borders is. With my ...
10 years, 9 months ago (2010-03-26 18:43:49 UTC) #2
Elliot Glaysher
On Fri, Mar 26, 2010 at 11:43 AM, <estade@chromium.org> wrote: > it seems this should ...
10 years, 9 months ago (2010-03-26 19:19:07 UTC) #3
Evan Stade
10 years, 9 months ago (2010-03-26 19:37:35 UTC) #4
lgtm

http://codereview.chromium.org/1442001/diff/4001/5003
File chrome/browser/gtk/gtk_theme_provider.cc (right):

http://codereview.chromium.org/1442001/diff/4001/5003#newcode11
chrome/browser/gtk/gtk_theme_provider.cc:11: #include "base/linux_util.h"
alphabet

http://codereview.chromium.org/1442001/diff/4001/5011
File net/proxy/proxy_config_service_linux.cc (right):

http://codereview.chromium.org/1442001/diff/4001/5011#newcode978
net/proxy/proxy_config_service_linux.cc:978: case
base::DESKTOP_ENVIRONMENT_XFCE:
XFCE before OTHER?

Powered by Google App Engine
This is Rietveld 408576698