Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 1435001: In build/gyp_chromium, if CHROMIUM_GYP_SYNTAX_CHECK is set to 1, run gyp with --check. (Closed)

Created:
10 years, 9 months ago by Robert Sesek
Modified:
9 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

In build/gyp_chromium, if CHROMIUM_GYP_SYNTAX_CHECK is set to 1, run gyp with --check. This is to eventually run gyp with syntax checking enabled on the buildbots. Enabling that will come in a later CL after all gyp errors are fixed. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42788

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/gyp_chromium View 1 chunk +6 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Robert Sesek
10 years, 9 months ago (2010-03-26 17:47:11 UTC) #1
Mark Mentovai
LGTM http://codereview.chromium.org/1435001/diff/1/2 File build/gyp_chromium (right): http://codereview.chromium.org/1435001/diff/1/2#newcode88 build/gyp_chromium:88: if syntax_check and int(syntax_check): bool() is marginally closer ...
10 years, 9 months ago (2010-03-26 17:53:45 UTC) #2
Robert Sesek
http://codereview.chromium.org/1435001/diff/1/2 File build/gyp_chromium (right): http://codereview.chromium.org/1435001/diff/1/2#newcode88 build/gyp_chromium:88: if syntax_check and int(syntax_check): On 2010/03/26 17:53:45, Mark Mentovai ...
10 years, 9 months ago (2010-03-26 17:57:35 UTC) #3
Mark Mentovai
10 years, 9 months ago (2010-03-26 17:58:13 UTC) #4
Hmm, guess so.  LGTM, then.

Powered by Google App Engine
This is Rietveld 408576698