Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2436)

Unified Diff: build/gyp_chromium

Issue 1435001: In build/gyp_chromium, if CHROMIUM_GYP_SYNTAX_CHECK is set to 1, run gyp with --check. (Closed)
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index c955e39a7c1995bf80ec9ddbc9a1e7df0de19967..9c87e82f16a982893528cf87c253f975d33f6795 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -82,6 +82,12 @@ if __name__ == '__main__':
if sys.platform != 'darwin':
args.append('--no-circular-check')
+ # If CHROMIUM_GYP_SYNTAX_CHECK is set to 1, it will invoke gyp with --check
+ # to enfore syntax checking.
+ syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
+ if syntax_check and int(syntax_check):
Mark Mentovai 2010/03/26 17:53:45 bool() is marginally closer to what you mean than
Robert Sesek 2010/03/26 17:57:35 That's what I thought, too. But |bool("0") == True
+ args.append('--check')
+
print 'Updating projects from gyp files...'
sys.stdout.flush()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698