Mac: Add geolocation content setting.

Mac: Add geolocation content setting.

The radio button seems to be non-functional; probably the backend probably isn't there yet.

xib changes: Added a location tab to contentsettings.xib, bind its radio buttons and normal button to the new methods in the controller. In the bubble, enable the "settings" button.

BUG=11246
TEST=content settings now has a "location" tab.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42827

[Nico, 2010-03-26 20:41:46]

Ignore the grd change, pkasting submitted that already and my changes will
disappear after syncing.

[viettrungluu, 2010-03-26 20:50:17]

Could you confirm that bit about the radio button and the backend?

http://codereview.chromium.org/1428002/diff/1/5
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1428002/diff/1/5#newcode123
chrome/browser/cocoa/content_blocked_bubble_controller.mm:123: return;  // Make
valgrind happy for now.
Bug #?

http://codereview.chromium.org/1428002/diff/1/7
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/1428002/diff/1/7#newcode360
chrome/browser/cocoa/content_settings_dialog_controller.mm:360: default:
Is ContentSetting an enum? Does the compiler warn when a switch () doesn't cover
all the possibilities? (I think so, at least on some platforms.)

If yes (to both), it'd be better to have this outside the switch (), unless some
things in the enum are intentionally not possible....

[Nico, 2010-03-26 20:54:10]

Backend bits: When clicking the radio button, asking infobars for geolocation
still show up for some reason. But since this is behind a flag and the windows
version of this will land soon, we'll probably fix this soon enough.

http://codereview.chromium.org/1428002/diff/1/5
File chrome/browser/cocoa/content_blocked_bubble_controller.mm (right):

http://codereview.chromium.org/1428002/diff/1/5#newcode123
chrome/browser/cocoa/content_blocked_bubble_controller.mm:123: return;  // Make
valgrind happy for now.
On 2010/03/26 20:50:18, viettrungluu wrote:
> Bug #?

N/A. This will go away later today when I implement the bubble for realz.

http://codereview.chromium.org/1428002/diff/1/7
File chrome/browser/cocoa/content_settings_dialog_controller.mm (right):

http://codereview.chromium.org/1428002/diff/1/7#newcode360
chrome/browser/cocoa/content_settings_dialog_controller.mm:360: default:
On 2010/03/26 20:50:18, viettrungluu wrote:
> Is ContentSetting an enum?

Yes.

> Does the compiler warn when a switch () doesn't cover
> all the possibilities? (I think so, at least on some platforms.)
> 
> If yes (to both), it'd be better to have this outside the switch (), unless
some
> things in the enum are intentionally not possible....

Yes, I intentionally don't have a case for every possible value. Also cf the
same for cookies a couple lines up.

[viettrungluu, 2010-03-26 20:55:37]

lgtm then