Mac: Add geolocation content setting.

chrome/browser/cocoa/content_settings_dialog_controller.mm

 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/cocoa/content_settings_dialog_controller.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "app/l10n_util.h"
 #include "base/mac_util.h"
 #include "chrome/browser/browser.h"
 #include "chrome/browser/browser_window.h"
 #import "chrome/browser/cocoa/content_exceptions_window_controller.h"
 #import "chrome/browser/cocoa/cookies_window_controller.h"
+#import "chrome/browser/geolocation/geolocation_content_settings_map.h"
 #import "chrome/browser/host_content_settings_map.h"
 #include "chrome/browser/pref_service.h"
 #include "chrome/browser/profile.h"
 #include "chrome/common/notification_service.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "grit/locale_settings.h"
 
 
 namespace {
 
 // Index of the "enabled" and "disabled" radio group settings in all tabs except
 // for the cookies tab.
 const NSInteger kEnabledIndex = 0;
 const NSInteger kDisabledIndex = 1;
 
 // Indices of the various cookie settings in the cookie radio group.
 const NSInteger kCookieEnabledIndex = 0;
 const NSInteger kCookieAskIndex = 1;
 const NSInteger kCookieDisabledIndex = 2;
 
 // Stores the currently visible content settings dialog, if any.
 ContentSettingsDialogController* g_instance = nil;
 
+// Indices of the various geolocation settings in the geolocation radio group.
+const NSInteger kGeolocationEnabledIndex = 0;
+const NSInteger kGeolocationAskIndex = 1;
+const NSInteger kGeolocationDisabledIndex = 2;
+
 }  // namespace
 
 
 @interface ContentSettingsDialogController(Private)
 - (id)initWithProfile:(Profile*)profile;
 - (void)selectTab:(ContentSettingsType)settingsType;
 - (void)showExceptionsForType:(ContentSettingsType)settingsType;
 
 // Properties that the radio groups and checkboxes are bound to.
 @property(assign, nonatomic) NSInteger cookieSettingIndex;
 @property(assign, nonatomic) BOOL blockThirdPartyCookies;
 @property(assign, nonatomic) BOOL clearSiteDataOnExit;
 @property(assign, nonatomic) NSInteger imagesEnabledIndex;
 @property(assign, nonatomic) NSInteger javaScriptEnabledIndex;
 @property(assign, nonatomic) NSInteger popupsEnabledIndex;
 @property(assign, nonatomic) NSInteger pluginsEnabledIndex;
+@property(assign, nonatomic) NSInteger geolocationSettingIndex;
+
 @end
 
 namespace ContentSettingsDialogControllerInternal {
 
 // A C++ class registered for changes in preferences.
 class PrefObserverBridge : public NotificationObserver {
  public:
   PrefObserverBridge(ContentSettingsDialogController* controller)
       : controller_(controller) {}
 
@@ skipping 186 matching lines @@
 }
 
 - (IBAction)showPluginsExceptions:(id)sender {
   [self showExceptionsForType:CONTENT_SETTINGS_TYPE_PLUGINS];
 }
 
 - (IBAction)showPopupsExceptions:(id)sender {
   [self showExceptionsForType:CONTENT_SETTINGS_TYPE_POPUPS];
 }
 
+- (IBAction)showGeolocationExceptions:(id)sender {
+  // TODO(thakis): Implement.
+  NOTIMPLEMENTED();
+}
+
 - (void)showExceptionsForType:(ContentSettingsType)settingsType {
   HostContentSettingsMap* settingsMap = profile_->GetHostContentSettingsMap();
   [ContentExceptionsWindowController showForType:settingsType
                                      settingsMap:settingsMap];
 }
 
 - (void)setImagesEnabledIndex:(NSInteger)value {
   ContentSetting setting = value == kEnabledIndex ?
       CONTENT_SETTING_ALLOW : CONTENT_SETTING_BLOCK;
   profile_->GetHostContentSettingsMap()->SetDefaultContentSetting(
@@ skipping 46 matching lines @@
 }
 
 - (NSInteger)popupsEnabledIndex {
   HostContentSettingsMap* settingsMap = profile_->GetHostContentSettingsMap();
   bool enabled =
       settingsMap->GetDefaultContentSetting(CONTENT_SETTINGS_TYPE_POPUPS) ==
       CONTENT_SETTING_ALLOW;
   return enabled ? kEnabledIndex : kDisabledIndex;
 }
 
+- (void)setGeolocationSettingIndex:(NSInteger)value {
+  ContentSetting setting = CONTENT_SETTING_DEFAULT;
+  switch (value) {
+    case kGeolocationEnabledIndex:  setting = CONTENT_SETTING_ALLOW; break;
+    case kGeolocationAskIndex:      setting = CONTENT_SETTING_ASK;   break;
+    case kGeolocationDisabledIndex: setting = CONTENT_SETTING_BLOCK; break;
+    default:
+      NOTREACHED();
+  }
+  profile_->GetGeolocationContentSettingsMap()->SetDefaultContentSetting(
+      setting);
+}
+
+- (NSInteger)geolocationSettingIndex {
+  ContentSetting setting =
+      profile_->GetGeolocationContentSettingsMap()->GetDefaultContentSetting();
+  switch (setting) {
+    case CONTENT_SETTING_ALLOW: return kGeolocationEnabledIndex;
+    case CONTENT_SETTING_ASK:   return kGeolocationAskIndex;
+    case CONTENT_SETTING_BLOCK: return kGeolocationDisabledIndex;
+    default:

[viettrungluu, 2010/03/26 20:50:18]

Is ContentSetting an enum? Does the compiler warn when a switch () doesn't cover
all the possibilities? (I think so, at least on some platforms.)

If yes (to both), it'd be better to have this outside the switch (), unless some
things in the enum are intentionally not possible....

[Nico, 2010/03/26 20:54:10]

Yes.
Yes, I intentionally don't have a case for every possible value. Also cf the
same for cookies a couple lines up.

+      NOTREACHED();
+      return kGeolocationAskIndex;
+  }
+}
+
 @end