Bump breakpad version to version 557, which improves how invalid argument CRT...

Bump breakpad version to version 557, which improves how invalid argument CRT reports are generated to allow sorting those dumps by stack signature.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=43081

[Mark Mentovai, 2010-03-26 17:01:22]

That’s quite a large version swing.  Watch for falling rocks.  LGTM.

siggi wrote:
> Reviewers: Mark Mentovai,
>
> Description:
> Bump breakpad version to version 557, which improves how invalid argument
> CRT
> reports are generated to allow sorting those dumps by stack signature.
>
> BUG=none
> TEST=none
>
>
> Please review this at http://codereview.chromium.org/1418001
>
> SVN Base: svn://chrome-svn/chrome/trunk/src/
>
> Affected files:
>  M     DEPS
>
>
> Index: DEPS
> ===================================================================
> --- DEPS        (revision 42769)
> +++ DEPS        (working copy)
> @@ -11,7 +11,7 @@
>
>  deps = {
>   "src/breakpad/src":
> -    "http://google-breakpad.googlecode.com/svn/trunk/src@452",
> +    "http://google-breakpad.googlecode.com/svn/trunk/src@557",
>
>   "src/build/util/support":
>     "/trunk/deps/support@20411",
>
>
>

[Sigurður Ásgeirsson, 2010-03-30 14:14:18]

Please take another look, some rock avoidance in there now.

[Mark Mentovai, 2010-03-30 14:18:51]

LGTM

[Mark Mentovai, 2010-03-30 16:26:52]

dynamic_cast crept into breakpad/src/common/dwarf/dwarf2reader.cc.
All of our builds use -fno-rtti.  The Mac official build builds this
file.

[Mark Mentovai, 2010-03-30 16:34:20]

I wrote:
> dynamic_cast crept into breakpad/src/common/dwarf/dwarf2reader.cc.
> All of our builds use -fno-rtti.  The Mac official build builds this
> file.

http://code.google.com/p/google-breakpad/issues/detail?id=379

[Lei Zhang, 2010-03-30 18:55:07]

On 2010/03/30 16:34:20, Mark Mentovai wrote:
> I wrote:
> > dynamic_cast crept into breakpad/src/common/dwarf/dwarf2reader.cc.
> > All of our builds use -fno-rtti.  The Mac official build builds this
> > file.
> 
> http://code.google.com/p/google-breakpad/issues/detail?id=379
> 

I think r461 breaks several utility programs on the Linux side. We need to clean
that up too.