Issue 14131: Fixes info bubble painting bug. This was happening because we were...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14131: Fixes info bubble painting bug. This was happening because we were... (Closed)

Created:
12 years ago by sky

Modified:
9 years, 7 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fixes info bubble painting bug. This was happening because we were using layered windows incorrectly. According to the docs if you invoke SetLayeredWindowAttributes, then you shouldn't invoke UpdateLayeredWindow (unless you remove then add the WS_EX_LAYERED style bit). My approach here is to disable the backing buffer for the info bubble. I had problems toggling the WS_EX_LAYERED at the end up the animation. The text field would not paint when I did this... BUG=5351 TEST=bookmark a page. When the bubble appears press shift-tab and make sure you see a focus rect around the remove link. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7063

Patch Set 1 #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+52 lines, -14 lines)			Patch
M	chrome/browser/views/info_bubble.cc	View	4 chunks	+11 lines, -6 lines	0 comments	Download
M	chrome/views/widget_win.h	View	2 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/views/widget_win.cc	View	7 chunks	+25 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

OK

Expand Messages | Collapse Messages