Fixes info bubble painting bug. This was happening because we were...

chrome/browser/views/info_bubble.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/views/info_bubble.h"
 
 #include "base/win_util.h"
 #include "chrome/app/theme/theme_resources.h"
 #include "chrome/browser/browser_window.h"
 #include "chrome/browser/views/frame/browser_view.h"
@@ skipping 90 matching lines @@
         .GetBitmapNamed(IDR_INFO_BUBBLE_CORNER_TOP_LEFT);
     kInfoBubbleCornerTopRight = ResourceBundle::GetSharedInstance()
         .GetBitmapNamed(IDR_INFO_BUBBLE_CORNER_TOP_RIGHT);
     kInfoBubbleCornerBottomLeft = ResourceBundle::GetSharedInstance()
         .GetBitmapNamed(IDR_INFO_BUBBLE_CORNER_BOTTOM_LEFT);
     kInfoBubbleCornerBottomRight = ResourceBundle::GetSharedInstance()
         .GetBitmapNamed(IDR_INFO_BUBBLE_CORNER_BOTTOM_RIGHT);
   }
   set_window_style(WS_POPUP | WS_CLIPCHILDREN);
   set_window_ex_style(WS_EX_LAYERED | WS_EX_TOOLWINDOW);
+  // Because we're going to change the alpha value of the layered window we
+  // don't want to use the offscreen buffer provided by WidgetWin.
+  SetUseLayeredBuffer(false);
   content_view_ = CreateContentView(content);
   gfx::Rect bounds = content_view_->
       CalculateWindowBounds(parent_hwnd, position_relative_to);
   set_initial_class_style(
       (win_util::GetWinVersion() < win_util::WINVERSION_XP) ?
       0 : CS_DROPSHADOW);
 
   WidgetWin::Init(parent_hwnd, bounds, true);
   SetContentsView(content_view_);
   // The preferred size may differ when parented. Ask for the bounds again
   // and if they differ reset the bounds.
   gfx::Rect parented_bounds = content_view_->
       CalculateWindowBounds(parent_hwnd, position_relative_to);
 
-  // Set our initial alpha to zero so we don't flicker at the user. This
-  // doesn't trigger UpdateLayeredWindow, which would explode our native
-  // controls.
-  SetLayeredAlpha(kMinimumAlpha);
-
   if (bounds != parented_bounds) {
     SetWindowPos(NULL, parented_bounds.x(), parented_bounds.y(),
                  parented_bounds.width(), parented_bounds.height(),
                  SWP_NOACTIVATE | SWP_NOREDRAW | SWP_NOZORDER);
     // Invoke ChangeSize, otherwise layered window isn't updated correctly.
     ChangeSize(0, CSize(parented_bounds.width(), parented_bounds.height()));
   }
 
   // Register the Escape accelerator for closing.
   views::FocusManager* focus_manager =
       views::FocusManager::GetFocusManager(GetHWND());
   focus_manager->RegisterAccelerator(views::Accelerator(VK_ESCAPE, false,
                                                         false, false),
                                      this);
 
+  // Set initial alpha value of the layered window.
+  SetLayeredWindowAttributes(GetHWND(),
+                             RGB(0xFF, 0xFF, 0xFF),
+                             kMinimumAlpha,
+                             LWA_ALPHA);
+
   fade_animation_.reset(new SlideAnimation(this));
   fade_animation_->Show();
 }
 
 void InfoBubble::Close() {
   Close(false);
 }
 
 void InfoBubble::AnimationProgressed(const Animation* animation) {
   int alpha = static_cast<int>(static_cast<double>
       (fade_animation_->GetCurrentValue() * (255.0 - kMinimumAlpha) +
       kMinimumAlpha));
 
   SetLayeredWindowAttributes(GetHWND(),
                              RGB(0xFF, 0xFF, 0xFF),
                              alpha,
                              LWA_ALPHA);
-  content_view_->SchedulePaint();
+  // Don't need to invoke paint as SetLayeredWindowAttributes handles that for
+  // us.
 }
 
 bool InfoBubble::AcceleratorPressed(const views::Accelerator& accelerator) {
   DCHECK(accelerator.GetKeyCode() == VK_ESCAPE);
   if (!delegate_ || delegate_->CloseOnEscape()) {
     Close(true);
     return true;
   }
   return false;
 }
@@ skipping 239 matching lines @@
     x -= kArrowXOffset;
   else
     x = x + kArrowXOffset - pref.width();
   if (IsTop()) {
     y = position_relative_to.bottom() + kArrowToContentPadding;
   } else {
     y = position_relative_to.y() - kArrowToContentPadding - pref.height();
   }
   return gfx::Rect(x, y, pref.width(), pref.height());
 }