Issue 14113: Remove few more errors in mac scons build.

Issue 14113: Remove few more errors in mac scons build. (Closed)

Created:
12 years ago by Paweł Hajdan Jr.

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai, pink (ping after 24hrs), sgk

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Remove few more errors in mac scons build. BUG=5525 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=6981

Patch Set 2 : '' #

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+43 lines, -16 lines)			Patch
M	base/base_lib.scons	View	1	1 chunk	+5 lines, -3 lines	0 comments	Download
M	base/base_unittests.scons	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	build/SConscript.main	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	skia/SConscript	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/SConscript	View	1	1 chunk	+18 lines, -2 lines	0 comments	Download
M	webkit/SConscript.port	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/glue/event_conversion.cc	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/plugins/plugin_instance.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/port/platform/image-decoders/gif/GIFImageReader.h	View	1	1 chunk	+5 lines, -5 lines	0 comments	Download
M	webkit/port/platform/image-decoders/png/PNGImageDecoder.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/tools/test_shell/SConscript	View	1	1 chunk	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM http://codereview.chromium.org/14113/diff/1/3 File base/base_lib.scons (right): http://codereview.chromium.org/14113/diff/1/3#newcode98 Line 98: elif env_dmg_fp['PLATFORM'] == 'darwin': Why not env['PLATFORM'] ...

12 years ago (2008-12-15 15:27:45 UTC) #2

Paweł Hajdan Jr.

Please check if this unification is ok. It's a bit ugly that usage of CCFLAGS/CXXFLAGS ...

12 years ago (2008-12-15 15:59:05 UTC) #4

Mark Mentovai

12 years ago (2008-12-15 16:02:08 UTC) #5

Seems fine.  Maybe we should figure out why we're using different vars on Mac
and Linux and see if it's possible to better unify them.  LGTM.

Expand Messages | Collapse Messages