Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1970)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: base/base_lib.scons

Issue 14113: Remove few more errors in mac scons build. (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 12 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/base_unittests.scons » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/base_lib.scons
===================================================================
--- base/base_lib.scons (revision 6978)
+++ base/base_lib.scons (working copy)
@@ -92,9 +92,11 @@
'/wd4554',
],
)
-elif env_dmg_fp['PLATFORM'] == 'posix':
- env_dmg_fp['CXXFLAGS'].remove('-Wall')
- env_dmg_fp['CXXFLAGS'].append('-Wno-write-strings')
+elif env_dmg_fp['PLATFORM'] in ('darwin', 'posix'):
+ for var in ['CCFLAGS', 'CXXFLAGS']:
+ if '-Wall' in env_dmg_fp[var]:
+ env_dmg_fp[var].remove('-Wall')
+ env_dmg_fp[var].append('-Wno-write-strings')
input_files.extend([
env_dmg_fp.Object('third_party/dmg_fp/dtoa.cc'),
« no previous file with comments | « no previous file | base/base_unittests.scons » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698