chrome/browser/download/download_manager.cc - Issue 1403001: Modifying the "dangerous download" algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_manager.cc

Issue 1403001: Modifying the "dangerous download" algorithm. (Closed)

Patch Set: Adding .sys and .drv as Dangerous extensions Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_manager.cc

diff --git a/chrome/browser/download/download_manager.cc b/chrome/browser/download/download_manager.cc

index c2b63f339d973488f9362fb48ee56b9105206bc9..133ca2930527974bb8196af1da3674cec72ee012 100644

--- a/chrome/browser/download/download_manager.cc

+++ b/chrome/browser/download/download_manager.cc

@@ -20,6 +20,7 @@

#include "chrome/browser/browser_list.h"

#include "chrome/browser/browser_process.h"

#include "chrome/browser/browser_thread.h"

+#include "chrome/browser/download/download_extensions.h"

#include "chrome/browser/download/download_file_manager.h"

#include "chrome/browser/download/download_history.h"

#include "chrome/browser/download/download_item.h"

@@ -836,7 +837,7 @@ bool DownloadManager::ShouldOpenFileBasedOnExtension(

FilePath::StringType extension = path.Extension();

if (extension.empty())

return false;

- if (download_util::IsExecutableExtension(extension))

+ if (!download_util::IsFileExtensionSafe(extension))

return false;

if (Extension::IsExtension(path))

return false;

« no previous file with comments | « chrome/browser/download/download_item.cc ('k') | chrome/browser/download/download_prefs.cc » ('j') | no next file with comments »