chrome/browser/download/download_item.cc - Issue 1403001: Modifying the "dangerous download" algorithm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/download/download_item.cc

Issue 1403001: Modifying the "dangerous download" algorithm. (Closed)

Patch Set: Adding .sys and .drv as Dangerous extensions Created 10 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/download/download_item.cc

diff --git a/chrome/browser/download/download_item.cc b/chrome/browser/download/download_item.cc

index 7d3afb0ce11741366393ebf956c7c0ae91037111..2feba505509f1241c75fdf00d248c879f9be755e 100644

--- a/chrome/browser/download/download_item.cc

+++ b/chrome/browser/download/download_item.cc

@@ -13,6 +13,7 @@

#include "base/utf_string_conversions.h"

#include "net/base/net_util.h"

#include "chrome/browser/browser_thread.h"

+#include "chrome/browser/download/download_extensions.h"

#include "chrome/browser/download/download_file_manager.h"

#include "chrome/browser/download/download_history.h"

#include "chrome/browser/download/download_manager.h"

@@ -196,7 +197,7 @@ void DownloadItem::NotifyObserversDownloadFileCompleted() {

bool DownloadItem::CanOpenDownload() {

return !Extension::IsExtension(target_name_) &&

- !download_util::IsExecutableFile(target_name_);

+ download_util::IsFileSafe(target_name_);

}

bool DownloadItem::ShouldOpenFileBasedOnExtension() {