Issue 1401002: Revert 42727 - ffmpeg roll chromium binaries...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1401002: Revert 42727 - ffmpeg roll chromium binaries... (Closed)

Created:
10 years, 9 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
fbarchard, scherkus (not reviewing)

CC:
chromium-reviews, fbarchard, pam+watch_chromium.org, awong, Alpha Left Google

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Revert 42727 - ffmpeg roll chromium binaries bug=none test=none TBR=fbarchard@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=42728

Patch Set 1 #

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -5 lines)			Patch
M	DEPS	View	1 chunk	+1 line, -1 line	0 comments	Download
M	media/base/pipeline_impl.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	media/tools/media_bench/media_bench.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

careful with the TBRs as it looks like some local changes slipped in :)

10 years, 9 months ago (2010-03-26 21:00:59 UTC) #2

fbarchard1

10 years, 9 months ago (2010-03-27 02:08:23 UTC) #3

That was a complete blunder... I didn't intend to commit, I was trying to
make the change list and upload.
Somehow the commit itself says TBR.
maybe gcl should ask if you intended to commit without doing an upload/tbr
or lgtm?

On Fri, Mar 26, 2010 at 2:00 PM, <scherkus@chromium.org> wrote:

> careful with the TBRs as it looks like some local changes slipped in :)
>
>
> http://codereview.chromium.org/1401002
>

Expand Messages | Collapse Messages