Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Unified Diff: src/ia32/virtual-frame-ia32.cc

Issue 140058: Fix bug in static type inference for loops. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1919169.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/virtual-frame-ia32.cc
diff --git a/src/ia32/virtual-frame-ia32.cc b/src/ia32/virtual-frame-ia32.cc
index 3d97a66fa0b8fc85a0a86d6b19dd6aeda287c18d..1a50b27e3f2167802ccac395e9d9fcf91c2d0036 100644
--- a/src/ia32/virtual-frame-ia32.cc
+++ b/src/ia32/virtual-frame-ia32.cc
@@ -220,7 +220,9 @@ void VirtualFrame::MakeMergable() {
}
// No need to set the copied flag---there are no copies of
// copies or constants so the original was not copied.
- elements_[i].set_static_type(element.static_type());
+
+ // Backwards jump targets can never know the type of a value.
+ elements_[i].set_static_type(StaticType::unknown());
} else {
// Clear the copy flag of non-constant, non-copy elements above
// the high water mark. They cannot be copied because copes are
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1919169.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698