Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(856)

Side by Side Diff: src/ia32/virtual-frame-ia32.cc

Issue 140058: Fix bug in static type inference for loops. (Closed)
Patch Set: Created 11 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1919169.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2009 the V8 project authors. All rights reserved. 1 // Copyright 2009 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 __ mov(fresh.reg(), backing_element.reg()); 213 __ mov(fresh.reg(), backing_element.reg());
214 } 214 }
215 } else { 215 } else {
216 ASSERT(backing_element.is_memory()); 216 ASSERT(backing_element.is_memory());
217 __ mov(fresh.reg(), Operand(ebp, fp_relative(element.index()))); 217 __ mov(fresh.reg(), Operand(ebp, fp_relative(element.index())));
218 } 218 }
219 } 219 }
220 } 220 }
221 // No need to set the copied flag---there are no copies of 221 // No need to set the copied flag---there are no copies of
222 // copies or constants so the original was not copied. 222 // copies or constants so the original was not copied.
223 elements_[i].set_static_type(element.static_type()); 223
224 // Backwards jump targets can never know the type of a value.
225 elements_[i].set_static_type(StaticType::unknown());
224 } else { 226 } else {
225 // Clear the copy flag of non-constant, non-copy elements above 227 // Clear the copy flag of non-constant, non-copy elements above
226 // the high water mark. They cannot be copied because copes are 228 // the high water mark. They cannot be copied because copes are
227 // always higher than their backing store and copies are not 229 // always higher than their backing store and copies are not
228 // allowed above the water mark. 230 // allowed above the water mark.
229 elements_[i].clear_copied(); 231 elements_[i].clear_copied();
230 } 232 }
231 } 233 }
232 } 234 }
233 235
(...skipping 845 matching lines...) Expand 10 before | Expand all | Expand 10 after
1079 ASSERT(stack_pointer_ == element_count() - 1); 1081 ASSERT(stack_pointer_ == element_count() - 1);
1080 elements_.Add(FrameElement::MemoryElement()); 1082 elements_.Add(FrameElement::MemoryElement());
1081 stack_pointer_++; 1083 stack_pointer_++;
1082 __ push(immediate); 1084 __ push(immediate);
1083 } 1085 }
1084 1086
1085 1087
1086 #undef __ 1088 #undef __
1087 1089
1088 } } // namespace v8::internal 1090 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | test/mjsunit/regress/regress-1919169.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698