Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1390003: add keyboard acclerators to login wizard... (Closed)

Created:
10 years, 9 months ago by rginda
Modified:
9 years, 7 months ago
Reviewers:
Chris Masone, zel
CC:
chromium-reviews, ben+cc_chromium.org
Visibility:
Public.

Description

add keyboard acclerators to login wizard This is to make it possible to put the login wizard into a known state for testing purposes. Ctrl-Alt-L navigates to the login screen, from there Atl-U focuses the username field Alt-P focuses the password field

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : fix lint warning #

Patch Set 4 : fix compile errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M chrome/browser/chromeos/login/login_manager_view.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_view.cc View 1 2 3 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.cc View 1 2 3 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
rginda
10 years, 9 months ago (2010-03-26 00:33:21 UTC) #1
zel
LGTM
10 years, 9 months ago (2010-03-26 01:14:44 UTC) #2
rginda
On 2010/03/26 01:14:44, zel wrote: > LGTM Somehow I missed the part of `gcl upload` ...
10 years, 9 months ago (2010-03-26 20:10:05 UTC) #3
zelidrag1
There is a minor code style problem at http://codereview.chromium.org/lint_patch/issue1390003_7001_8002 On Fri, Mar 26, 2010 at ...
10 years, 9 months ago (2010-03-26 20:12:38 UTC) #4
rginda
That would make the previous line longer than 80, but I can add a break ...
10 years, 9 months ago (2010-03-26 20:16:04 UTC) #5
rginda
10 years, 9 months ago (2010-03-26 20:18:14 UTC) #6
rginda
10 years, 9 months ago (2010-03-26 21:45:47 UTC) #7
rginda
10 years, 9 months ago (2010-03-26 21:48:08 UTC) #8
Sorry, I got sloppy on the update and assumed it'd build.  Turns out the
constant I relied on got moved to a class, and it stopped building.  This set
fixes the issue, sorry for burning your time on it Zel.

Powered by Google App Engine
This is Rietveld 408576698